You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Onboarding - Onboarding video does not have an audio #41000
Version Number: 1.4.66-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Activity
melvin-bot commentedon Apr 25, 2024
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 25, 2024
@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
mountiny commentedon Apr 26, 2024
This is a new feature so not a blocker, discussing here if the videos should have sounds, I did not have the sounds when testing it before
12 remaining items
dubielzyk-expensify commentedon May 7, 2024
No idea why this happens. Thought everyone had access to it. Shared with you directly regardless 😄
francoisl commentedon May 9, 2024
Sorry @dubielzyk-expensify the link https://www.dropbox.com/home/Expensify/Design/Product%20GIFs/01_MP4 still doesn't work, however I can access https://www.dropbox.com/home/01_MP4. To confirm, the new videos we need to compress are the ones whose name ends with
-sound.mp4, right?dubielzyk-expensify commentedon May 10, 2024
Correct.
No idea why this happens. cc @Expensify/design
dannymcclain commentedon May 10, 2024
Dang no idea on that either. The permissions for that folder (and all the ones above it) look correct? That's odd.
shawnborton commentedon May 10, 2024
No idea either... we should totally ditch Dropbox for Drive at some point but that's a different conversation.
shawnborton commentedon May 10, 2024
But yeah, in the meantime, maybe we put these on Drive for Francois or something.
francoisl commentedon May 10, 2024
No worries, I'm still able to see the new videos. Thanks guys!
I'll send a PR shortly to use the new videos. I also wrote the command I use to rescale videos in Stackoverflow https://stackoverflowteams.com/c/expensify/questions/19224/19225#19225
mountiny commentedon May 13, 2024
PR approved, waiting for design feedback about the default sound settings
dubielzyk-expensify commentedon May 27, 2024
We've left sound off by default, but I believe that PR has been merged, so are we good to close this one?
mountiny commentedon May 28, 2024
yeah, nothing to pay