Skip to content

Onboarding - Onboarding video does not have an audio #41000

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40688

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Sign in with a new Gmail account
  3. On the Onboarding select "Track business spend for taxes" as a purpose and click on continue
  4. Input first name and last name and click on continue
  5. Input a business name and click on continue
  6. When the Welcome to Expensify modal opens up click on the unmute button to check the audio and notice it works fine
  7. Open Concierge chat and wait for the backend to send attachment
  8. Once the attachment loads play the video and unmute it

Expected Result:

Audio works fine and can be heard

Actual Result:

There is no audio for the video

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6461727_1714058331742.bandicam_2024-04-25_18-15-16-011.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Apr 25, 2024

    @melvin-bot

    Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 25, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Apr 25, 2024

    @lanitochka17
    Author

    @jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 26, 2024
  5. mountiny commented on Apr 26, 2024

    @mountiny
    Contributor

    This is a new feature so not a blocker, discussing here if the videos should have sounds, I did not have the sounds when testing it before

  6. 12 remaining items

  7. dubielzyk-expensify commented on May 7, 2024

    @dubielzyk-expensify
    Contributor

    No idea why this happens. Thought everyone had access to it. Shared with you directly regardless 😄

  8. francoisl commented on May 9, 2024

    @francoisl
    Contributor

    Sorry @dubielzyk-expensify the link https://www.dropbox.com/home/Expensify/Design/Product%20GIFs/01_MP4 still doesn't work, however I can access https://www.dropbox.com/home/01_MP4. To confirm, the new videos we need to compress are the ones whose name ends with -sound.mp4, right?

  9. dubielzyk-expensify commented on May 10, 2024

    @dubielzyk-expensify
    Contributor

    To confirm, the new videos we need to compress are the ones whose name ends with -sound.mp4, right?

    Correct.

    No idea why this happens. cc @Expensify/design

  10. dannymcclain commented on May 10, 2024

    @dannymcclain
    Contributor

    Dang no idea on that either. The permissions for that folder (and all the ones above it) look correct? That's odd.

  11. shawnborton commented on May 10, 2024

    @shawnborton
    Contributor

    No idea either... we should totally ditch Dropbox for Drive at some point but that's a different conversation.

  12. shawnborton commented on May 10, 2024

    @shawnborton
    Contributor

    But yeah, in the meantime, maybe we put these on Drive for Francois or something.

  13. francoisl commented on May 10, 2024

    @francoisl
    Contributor

    No worries, I'm still able to see the new videos. Thanks guys!

    I'll send a PR shortly to use the new videos. I also wrote the command I use to rescale videos in Stackoverflow https://stackoverflowteams.com/c/expensify/questions/19224/19225#19225

  14. mountiny commented on May 13, 2024

    @mountiny
    Contributor

    PR approved, waiting for design feedback about the default sound settings

  15. dubielzyk-expensify commented on May 27, 2024

    @dubielzyk-expensify
    Contributor

    We've left sound off by default, but I believe that PR has been merged, so are we good to close this one?

  16. mountiny commented on May 28, 2024

    @mountiny
    Contributor

    yeah, nothing to pay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions