[HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] [Wave Collect][QBO] Fix the command name

Fix the API command name from UpdatePolicyConnectionConfig to UpdatePolicyConnectionConfiguration

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@hayata-suenaga

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
[@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hayata-suenaga] Determine if we should create a regression test for this bug.
[@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The regression was caused by the PR worked by one of the expert agency engineers. We don't need regression tests for this.

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix the command name #41002

If no regressions arise, payment will be issued on 2024-05-06. 🎊

@hayata-suenaga

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
[@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hayata-suenaga] Determine if we should create a regression test for this bug.
[@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Melvin, you crated the checklist twice 😓

The PR was deployed to production and there is no payment needed for this issue. Closing this 🙇

Navigation Menu

Repository navigation

[HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] [Wave Collect][QBO] Fix the command name #41001

2 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] [Wave Collect][QBO] Fix the command name #41001

Description

Activity

melvin-bot commented on Apr 25, 2024

2 remaining items

melvin-bot commented on Apr 26, 2024

hayata-suenaga commented on Apr 29, 2024

melvin-bot commented on Apr 29, 2024

melvin-bot commented on Apr 29, 2024

hayata-suenaga commented on Apr 30, 2024

hayata-suenaga commented on May 6, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions