You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-13] [$250] [QBO] "Last synced just now" text doesn't update #41045
Observe the text still reads "Last synced just now"
Expected Result:
On OldDot the way we handle it is by checking the lastSync timestamp from the policy on page load, and then compute a human-friendly time difference with it. Every time you/auto-sync syncs the connection it's updated here.
Actual Result:
Despite hours elapsing the text still reads: "Last synced just now" even after a page refresh, suggesting this is just a static value currently.
Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-][$250] [QBO] "Last synced just now" text doesn't update[/-][+][HOLD for payment 2024-06-13] [$250] [QBO] "Last synced just now" text doesn't update[/+]on Jun 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Apr 25, 2024
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
trjExpensify commentedon Apr 25, 2024
Haven't moved this on yet, as I think we might need to hold on:
https://github.com/Expensify/Web-Expensify/pull/41822
#41044
trjExpensify commentedon Apr 26, 2024
Confirmed we don't need a hold on those PRs, moving it on.
[-][QBO] "Last synced just now" text doesn't update[/-][+][$250] [QBO] "Last synced just now" text doesn't update[/+]melvin-bot commentedon Apr 26, 2024
Job added to Upwork: https://www.upwork.com/jobs/~016f30631fa560635c
melvin-bot commentedon Apr 26, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)tienifr commentedon Apr 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Despite hours elapsing the text still reads: "Last synced just now" even after a page refresh, suggesting this is just a static value currently.
What is the root cause of that problem?
We're showing
Last synced just nowinApp/src/pages/workspace/accounting/PolicyAccountingPage.tsx
Lines 98 to 100 in 42d4ed7
and it's just a static value
What changes do you think we should make in order to solve the problem?
lastSynctimestamp (SyncPolicyToQuickbooksOnline command). We need to update it optimistically toolastSyncto the current timeWe can update this value every 10 mins (5 mins, ...)
What alternative solutions did you explore? (Optional)
NA
30 remaining items
[-][$250] [QBO] "Last synced just now" text doesn't update[/-][+][HOLD for payment 2024-06-13] [$250] [QBO] "Last synced just now" text doesn't update[/+]melvin-bot commentedon Jun 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon Jun 13, 2024
We won't need a regression test for this, as they'll be added centrally with the QBO project.
Payment summary as follows:
@Ollyws feel free to send a request, @tienifr I've paid you in Upwork. Closing!
Ollyws commentedon Jun 13, 2024
Requested in ND.
JmillsExpensify commentedon Jun 13, 2024
$250 approved for @Ollyws