Skip to content

[HOLD for payment 2024-06-13] [$250] [QBO] "Last synced just now" text doesn't update #41045

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.66-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714057390428649?thread_ts=1714057353.559839&cid=C036QM0SLJK

Action Performed:

  1. Connect to QBO
  2. Observe the "Last synced just now" text
  3. Go have a coffee for 10mins
  4. Come back
  5. Observe the text still reads "Last synced just now"

Expected Result:

On OldDot the way we handle it is by checking the lastSync timestamp from the policy on page load, and then compute a human-friendly time difference with it. Every time you/auto-sync syncs the connection it's updated here.

Actual Result:

Despite hours elapsing the text still reads: "Last synced just now" even after a page refresh, suggesting this is just a static value currently.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

View all open jobs on GitHub

CC: @hayata-suenaga @aldo-expensify @teneeto @narefyev91 @zanyrenney

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016f30631fa560635c
  • Upwork Job ID: 1783647518731452416
  • Last Price Increase: 2024-04-26
  • Automatic offers:
    • Ollyws | Reviewer | 0
    • tienifr | Contributor | 0
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 25, 2024
  2. self-assigned this
    on Apr 25, 2024
  3. melvin-bot commented on Apr 25, 2024

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  4. trjExpensify commented on Apr 25, 2024

    @trjExpensify
    ContributorAuthor

    Haven't moved this on yet, as I think we might need to hold on:

    https://github.com/Expensify/Web-Expensify/pull/41822
    #41044

  5. trjExpensify commented on Apr 26, 2024

    @trjExpensify
    ContributorAuthor

    Confirmed we don't need a hold on those PRs, moving it on.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 26, 2024
  7. changed the title [-][QBO] "Last synced just now" text doesn't update[/-] [+][$250] [QBO] "Last synced just now" text doesn't update[/+] on Apr 26, 2024
  8. melvin-bot commented on Apr 26, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 26, 2024
  10. melvin-bot commented on Apr 26, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  11. tienifr commented on Apr 26, 2024

    @tienifr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Despite hours elapsing the text still reads: "Last synced just now" even after a page refresh, suggesting this is just a static value currently.

    What is the root cause of that problem?

    We're showing Last synced just now in

    description: isSyncInProgress
    ? translate('workspace.accounting.connections.syncStageName', connectionSyncProgress.stageInProgress)
    : translate('workspace.accounting.lastSync'),

    and it's just a static value

    What changes do you think we should make in order to solve the problem?

    1. BE should return new value to indicate the lastSync timestamp (SyncPolicyToQuickbooksOnline command). We need to update it optimistically too
    2. Use it value to calculate the difference in time from lastSync to the current time

    We can update this value every 10 mins (5 mins, ...)

    What alternative solutions did you explore? (Optional)

    NA

  12. 30 remaining items

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 6, 2024
  14. changed the title [-][$250] [QBO] "Last synced just now" text doesn't update[/-] [+][HOLD for payment 2024-06-13] [$250] [QBO] "Last synced just now" text doesn't update[/+] on Jun 6, 2024
  15. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-13. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. trjExpensify commented on Jun 13, 2024

    @trjExpensify
    ContributorAuthor

    We won't need a regression test for this, as they'll be added centrally with the QBO project.

    Payment summary as follows:

    @Ollyws feel free to send a request, @tienifr I've paid you in Upwork. Closing!

  19. Ollyws commented on Jun 13, 2024

    @Ollyws
    Contributor

    Requested in ND.

  20. JmillsExpensify commented on Jun 13, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions