You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number. #41078
changed the title [-]Room-User is allowed to invite via mentions invalid number.[/-][+][$250] Room-User is allowed to invite via mentions invalid number.[/+]on Apr 29, 2024
@lschurr I want to discuss about the expected behavior here. In this case, when we sent an invalid phone number, the whisper message shouldn't be displayed or it's displayed but we can't click the Invite button?
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
[@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hungvu193] Determine if we should create a regression test for this bug.
[@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room-User is allowed to invite via mentions invalid number.[/-][+][HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/+]on Jun 13, 2024
changed the title [-][HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/+]on Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
[@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hungvu193] Determine if we should create a regression test for this bug.
[@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Apr 26, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon Apr 26, 2024
We think this issue might be related to the #vip-vsb.
[-]Room-User is allowed to invite via mentions invalid number.[/-][+][$250] Room-User is allowed to invite via mentions invalid number.[/+]melvin-bot commentedon Apr 29, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01cdf72ac69795bc85
melvin-bot commentedon Apr 29, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)hungvu193 commentedon May 1, 2024
@lschurr I want to discuss about the expected behavior here. In this case, when we sent an invalid phone number, the whisper message shouldn't be displayed or it's displayed but we can't click the
Invitebutton?95 remaining items
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room-User is allowed to invite via mentions invalid number.[/-][+][HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/+]melvin-bot commentedon Jun 20, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lschurr commentedon Jun 20, 2024
Payment summary:
lschurr commentedon Jun 20, 2024
Do we need to leave this open for the Deploy Blocker message? #41078 (comment)
@nkdengineer @hungvu193
nkdengineer commentedon Jun 20, 2024
It's not a blocker from our PR here. Ref: #44085 (comment).
lschurr commentedon Jun 20, 2024
Great! Closing this one out since it's paid.
[-][HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/+]melvin-bot commentedon Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: