Skip to content

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number. #41078

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4513241
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a room report
  3. Enter @+91 and send the message
  4. Tap invite
  5. Note invited message
  6. Tap header--members---invite
  7. Enter +91
  8. Note no options to select and invite the contact is shown

Expected Result:

User must not be allowed to invite via mentions invalid number.

Actual Result:

User is allowed to invite via mentions invalid number.
Tapping header -- members -- invite, user unable to invite +91 but via mentions can invite.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6462540_1714115844874.mev.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cdf72ac69795bc85
  • Upwork Job ID: 1784976134411239424
  • Last Price Increase: 2024-05-09
  • Automatic offers:
    • hungvu193 | Reviewer | 0
    • nkdengineer | Contributor | 0
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 26, 2024
  2. melvin-bot commented on Apr 26, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. izarutskaya commented on Apr 26, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 29, 2024
  5. changed the title [-]Room-User is allowed to invite via mentions invalid number.[/-] [+][$250] Room-User is allowed to invite via mentions invalid number.[/+] on Apr 29, 2024
  6. melvin-bot commented on Apr 29, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 29, 2024
  8. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

  9. hungvu193 commented on May 1, 2024

    @hungvu193
    Contributor

    @lschurr I want to discuss about the expected behavior here. In this case, when we sent an invalid phone number, the whisper message shouldn't be displayed or it's displayed but we can't click the Invite button?

  10. 95 remaining items

  11. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
    • [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hungvu193] Determine if we should create a regression test for this bug.
    • [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. changed the title [-][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room-User is allowed to invite via mentions invalid number.[/-] [+][HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/+] on Jun 13, 2024
  13. melvin-bot commented on Jun 20, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. lschurr commented on Jun 20, 2024

    @lschurr
    Contributor

    Payment summary:

  15. lschurr commented on Jun 20, 2024

    @lschurr
    Contributor

    Do we need to leave this open for the Deploy Blocker message? #41078 (comment)

    @nkdengineer @hungvu193

  16. nkdengineer commented on Jun 20, 2024

    @nkdengineer
    Contributor

    It's not a blocker from our PR here. Ref: #44085 (comment).

  17. lschurr commented on Jun 20, 2024

    @lschurr
    Contributor

    Great! Closing this one out since it's paid.

  18. changed the title [-][HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/-] [+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number.[/+] on Jun 21, 2024
  19. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
    • [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hungvu193] Determine if we should create a regression test for this bug.
    • [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions