Repository navigation
[$250] IOS - More features - Enabled feature is not showing in workspace page after enabling it #41142
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Launch New Expensify app
- Go to Account settings > Workspaces
- Create a new workspace
- Go to More features
- Enable any feature
Expected Result:
App will redirect to the previous page with the enabled feature
Actual Result:
The enabled feature is not showing in workspace page after enabling it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6463515_1714196915920.feature_ios.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~011cc719021a75da07
- Upwork Job ID: 1784283404020502528
- Last Price Increase: 2024-04-27
Activity
github-actions commentedon Apr 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Apr 27, 2024
Triggered auto assignment to @roryabraham (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Apr 27, 2024
@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 27, 2024
We think that this bug might be related to #vip-vsp
roryabraham commentedon Apr 27, 2024
This does appear to be a deploy-blocking bug. Going to make it external now
melvin-bot commentedon Apr 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~011cc719021a75da07
[-]IOS - More features - Enabled feature is not showing in workspace page after enabling it[/-][+][$250] IOS - More features - Enabled feature is not showing in workspace page after enabling it[/+]melvin-bot commentedon Apr 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)Krishna2323 commentedon Apr 27, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOS - More features - Enabled feature is not showing in workspace page after enabling it
What is the root cause of that problem?
Offending PR: #40369
In the PR mentioned above we introduced
didScreenTransitionEndto delay the transition start so it only starts after navigation transition is ended, but due to this bug in navigation,didScreenTransitionEndis not correctly updated in iOS. I haven't found the exact reason why does this happen.What changes do you think we should make in order to solve the problem?
We should remove
didScreenTransitionEndcheck and instead usesetTimeoutoritemEnterDelayto delay the transition if needed.What alternative solutions did you explore? (Optional)
roryabraham commentedon Apr 28, 2024
Kicked off an AdHoc build for a revert of #40369 to see if that fixes this problem.
mollfpr commentedon Apr 29, 2024
As mentioned in the @Krishna2323 proposal,
didScreenTransitionEndis bugging for iOS and probably added to avoid the animation starting while the transition is happening. Removing it from the check is to fix this issue, but I'm not sure the case for the check where is needed.kavimuru commentedon Apr 29, 2024
Two testers tried to reproduce. One wasn't able to while the other was able to.
RPReplay_Final1714395426.MP4
RPReplay_Final1714396036.MP4
francoisl commentedon Apr 29, 2024
@roryabraham did that AdHoc build fix the issue? Should we go ahead with a revert or with @Krishna2323's proposal in this case?
thienlnam commentedon Apr 29, 2024
I was testing the adhoc, and it seemed to work fine after this revert
thienlnam commentedon Apr 29, 2024
We're having the revert CPed