Repository navigation
New Expensify icon is not centered in the about page #4119
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Log in to e.cash
- Navigate to Settings>About page
Expected Result:
New Expensify icon should be centered
Actual Result:
New Expensify icon is left justified.
Workaround:
No need for workaround, visual issue.
Platform:
Where is this issue occurring?
Web ✔️
iOS✔️
Android✔️
Desktop App✔️
Mobile Web✔️
Version Number: 1.0.79-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
From @Beamanator https://expensify.slack.com/archives/C01GTK53T8Q/p1626342434313600
The e.cash icon position & size changed recently on the About page (was centered, now left justified) - does it look ok to everyone? I think it looks a bit out of place now - maybe the version number should not be centered anymore or the icon should still be centered
Activity
MelvinBot commentedon Jul 16, 2021
Triggered auto assignment to @mallenexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.isagoico commentedon Jul 16, 2021
@mallenexpensify My bad, I mistakenly created the issue with the incorrect label, fixing it.
MelvinBot commentedon Jul 16, 2021
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Jul 21, 2021
Triggered auto assignment to @jboniface (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.AndrewGable commentedon Jul 21, 2021
Looks like a great external issue 🤙
4 remaining items
helaoutar commentedon Jul 21, 2021
This would be fixed by adding a
align-items: centertosettingsPageBodywithinsrc/styles/styles.js.aliabbasmalik8 commentedon Jul 21, 2021
PROPOSAL
position can fix by adding
alignItems: 'center',at this position.App/src/pages/settings/AboutPage.js
Line 91 in 2d673cc
and also a minor update
<Logo />from<Logo height={100} />App/src/pages/settings/AboutPage.js
Line 92 in 2d673cc
and for size, if we want to increase logo size then we need big size logo svg because the current logo svg has size 52px width and height or we can update height/width in
new-expensify.svg.Thanks
after applied styling on the web
Julesssss commentedon Jul 22, 2021
Hi @helaoutar. As you submitted the first proposal would you like to take the issue?
jboniface commentedon Jul 22, 2021
@helaoutar I went ahead and hired you for this.
roryabraham commentedon Jul 27, 2021
The PR to fix this caused a minor regression, reverting it here.
helaoutar commentedon Aug 2, 2021
The regression was fixed about a week ago in this PR: #4243
roryabraham commentedon Aug 3, 2021
Yep, that's correct! @jboniface let's make sure @helaoutar is paid for the Upwork job.
jboniface commentedon Aug 3, 2021
ok paid and closing