Repository navigation
[HOLD for payment 2024-06-05] [HOLD for payment 2024-05-22] [QBO] Implement support for importing more than one of Classes, Customers/Projects or Locations on the tags page #41279
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.68-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714438462878199?thread_ts=1714400674.229349&cid=C036QM0SLJK
Action Performed:
- Create a workspace on NewDot
- Go to More Features > Tags > Enable (you need this step for now because otherwise Tags won't show in the LHN after you connect to QBO to see the imported coding, apparently that's going to be worked on https://github.com/Expensify/Expensify/issues/387834#issuecomment-2083773292)
- Connect to QBO
- Go to
Import - Check both
ClassesandCustomers/ProjectsareImported, displayed as tags(should be the default like OldDot for now) - Go to the
Tagspage in the LHN - Observe only the values for
Classesare shown on the page
Expected Result:
- When more than one of
Classes,Customers/ProjectsorLocationsare selected for import, the Tags page table will represent each distinct tag level imported from QBO - If the tag level is required,
Requiredwill be added to the status column in the table instead ofEnabled ||Disabled`
- Behind the "Settings" button on the
Tagspage header in the RHP:
3a. the toggle for "Members must tag all spend" will remain, allowing users to bulk toggle on/off making all tag levels mandatory.
3b. theCustom tag namefield will be removed; users will be able to set theCustom tag namea level deeper for each of the tag levels (see 4b. below)
- Clicking on a tag level name in the table will open the RHP, which will contain:
4a. Arequiredtoggle, when enabled it makes the tag level required coding on the workspace and setsRequiredin the mainTagspage table
4b. ACustom tag name >push input row, that opens a simple "Custom tag name" page with a text input to rename the tag level.
4c. A list of all of the tag values for that tag level (that opens up the individual tag value edit page with the same permissions and logic that exists today).
4d. checkboxes right-aligned each of the tag values to facilitate bulk select capabilities via the [Selected X v] button with the same permissions and logic that exists today.
Actual Result:
Only the first level of tag is shown in the Tags page table, additional levels imported are ignored.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
None
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
See expected results for the intended solution. Below is today:
CC: @hayata-suenaga @aldo-expensify @zanyrenney @narefyev91 @teneeto
Activity
melvin-bot commentedon Apr 30, 2024
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
narefyev91 commentedon Apr 30, 2024
Will start working on this one
hayata-suenaga commentedon Apr 30, 2024
Are there two PRs going on? @s77rt and @narefyev91
#41337
#41351
19 remaining items
melvin-bot commentedon May 22, 2024
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
ikevin127 commentedon May 23, 2024
@trjExpensify I reviewed PR #41351 as C+. There were some regressions. Is there any payment due here given the facts ?
trjExpensify commentedon May 23, 2024
Yeah, just the one from my perspective, so I've sent offers for $250. 👍
trjExpensify commentedon May 23, 2024
@ikevin127 - paid!
trjExpensify commentedon May 23, 2024
@s77rt - paid!
[-][HOLD for payment 2024-05-22] [QBO] Implement support for importing more than one of `Classes`, `Customers/Projects` or `Locations` on the tags page[/-][+][HOLD for payment 2024-06-05] [HOLD for payment 2024-05-22] [QBO] Implement support for importing more than one of `Classes`, `Customers/Projects` or `Locations` on the tags page[/+]melvin-bot commentedon May 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: