Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] Deeplinking to a whisper results in "hmm it is not here " page #41370

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.68-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714415566362469

Action Performed:

  1. Copy a link to a whisper in a chat
  2. Send it to someone else who doesn't have access to that whisper, but who does have access to the chat.
  3. Have that other person click the link

Expected Result:

They should be taken to the report as if they just opened it, and no comment should be linked.

Actual Result:

hmm it's not here page is shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

404.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @MonilBhavsar
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012634f8ccbb4f7594
  • Upwork Job ID: 1790412850565140480
  • Last Price Increase: 2024-05-22
  • Automatic offers:
    • tienifr | Contributor | 102448221

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 30, 2024
  2. melvin-bot commented on Apr 30, 2024

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. laurenreidexpensify commented on May 1, 2024

    @laurenreidexpensify
    Contributor

    @roryabraham which roadmap project do you think this is linked to?

  4. melvin-bot commented on May 7, 2024

    @melvin-bot

    @laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

  5. laurenreidexpensify commented on May 7, 2024

    @laurenreidexpensify
    Contributor

    @roryabraham I haven't made this external yet - can you confirm if you think this is connected to a roadmap project? thanks

  6. laurenreidexpensify commented on May 10, 2024

    @laurenreidexpensify
    Contributor

    @roryabraham bump thanks

  7. melvin-bot commented on May 13, 2024

    @melvin-bot

    @roryabraham, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. 53 remaining items

  9. MonilBhavsar commented on Jun 19, 2024

    @MonilBhavsar
    Contributor

    @allroundexperts mind doing the checklist when you have a moment, please

  10. laurenreidexpensify commented on Jun 19, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

  11. laurenreidexpensify commented on Jun 20, 2024

    @laurenreidexpensify
    Contributor

    @MonilBhavsar can you do a me a favour, when @allroundexperts confirms checklist can you please close out and write the regression test (if needed) using this template - https://github.com/Expensify/Expensify/issues/new?assignees=applausebot&labels=QA%2C+Daily%2C+qa-test&projects=&template=AddOrUpdateQATests_TEMPLATE.md&title=QA+-+Add%2FUpdate+test+to+TestRail. I am going parental leave for rest of year tomorrow and seems a bit unnecessary to assign a BZ for that outstanding step. Thanks!

  12. MonilBhavsar commented on Jun 20, 2024

    @MonilBhavsar
    Contributor

    Yes of course!

  13. added and removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jun 21, 2024
  14. allroundexperts commented on Jun 23, 2024

    @allroundexperts
    Contributor

    Checklist

    1. HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking #30269
    2. https://github.com/Expensify/App/pull/30269/files#r1650198707
    3. N/A
    4. A regression test would be helpful. The test steps given in the OP should be sufficient.
  15. MonilBhavsar commented on Jun 24, 2024

    @MonilBhavsar
    Contributor
  16. JmillsExpensify commented on Jul 20, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions