Repository navigation
[Awaiting Payment 25th June] [QBO] Implement the Required toggle in the RHP with multiLevel tags. #41374
Description
Coming from here and a follow-up to this PR.
- We need to implement a new command to allow making an individual tag level required (i.e Customers required, Classes not required)
- Add the
Requiredtoggle in the RHP of each tag level when multiTags are enabled with QBO, like so:
CC: @luacmartins @s77rt @hayata-suenaga @aldo-expensify @zanyrenney
Activity
melvin-bot commentedon May 1, 2024
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.
trjExpensify commentedon May 10, 2024
That PR is still in review.
trjExpensify commentedon May 14, 2024
That PR has merged. @hayata-suenaga this is backend right to implement that command?
hayata-suenaga commentedon May 14, 2024
@trjExpensify, yes it involves the backend change.
Currently, we have
SetPolicyRequiresTag.That code is just enabling all tags in the tags list if there is a tags list (I assume this means that the parent level tags or multi level tags).
We either need to create a new Web-E command or modify the existing command to accomodate the multi level tag situation.
I'll try to work on this but might need some help from @aldo-expensify. I'll open a draft PR today and assign @aldo-expensify so that we can work together.
trjExpensify commentedon May 14, 2024
Cool, I was looking at this on OldDot early to see what we call when we set one of the levels as required:
.. and equally, enable/disable one of the imported tag list's tag values:
Not sure if you looked at that, or if it's helpful here.
18 remaining items
hayata-suenaga commentedon Jun 19, 2024
Yes, Rodrigo is working on a regression fix in this PR
hayata-suenaga commentedon Jun 24, 2024
The fix for the regression was deployed to production.
The payment is handled in this issue. Closing this issue now. Thank you everyone!
trjExpensify commentedon Jun 24, 2024
Alright, but doesn't that mean @s77rt is required payment of $125 for the initial PR?
hayata-suenaga commentedon Jun 25, 2024
that's right! Good thing I didn't close this issue 😓
hayata-suenaga commentedon Jun 25, 2024
@trjExpensify, if you could handle that payment, I'd appreciate it 🙇
trjExpensify commentedon Jun 25, 2024
Cool, @s77rt sent you an offer! Payment summary as follows:
Thanks!
[-][QBO] Implement the `Required` toggle in the RHP with multiLevel tags.[/-][+][Awaiting Payment 25th June] [QBO] Implement the `Required` toggle in the RHP with multiLevel tags.[/+]s77rt commentedon Jun 25, 2024
@trjExpensify Accepted! Thanks!
trjExpensify commentedon Jun 25, 2024
Paid!