Repository navigation
[HOLD for payment 2024-05-20] [QAB] Update the QAB for Pay someone to be Pay %firstName% instead #41468
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.69-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714588923919309?thread_ts=1714400587.768059&cid=C036QM0SLJK
Action Performed:
- Go to global create >
Pay someone> enter an amount > confirm - Reopen global create
- Observe the quick action reads
Pay someone
Expected Result:
Since we’ve updated Send money to Pay someone, one thing we've done in the DM create menu is change the label name to Pay %firstName%. Let's do the same in the quick action button, like so.
If a displayName has been set:
Pay %firstName%
%primaryLogin%
If a displayName hasn't been set, then:
Pay %primaryLogin%
Actual Result:
The quick action button reads Pay someone, which was intended initially.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A, design improvement.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon May 2, 2024
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.
Gonals commentedon May 2, 2024
@trjExpensify, I think we made a wrong assumption here. The subtitle is not the primary login of the user, but the report name, which is the primary login when there is no name set, and the full name when it is:
I think it makes sense to hide it in all cases for this flow, as it will always either match the
someoneinPay someoneor be something like:Pay Alberto
Alberto Cela
trjExpensify commentedon May 2, 2024
Cool, so the two variations I would say are:
Gonals commentedon May 3, 2024
I'm fine with this, but why not omit the Subtitle in both cases and just have either:
Pay Sara Couto
or
Pay scv@expensify.com
?
trjExpensify commentedon May 3, 2024
Because the left is more standard in the pattern I would say. The exception we use then being when someone doesn't set a displayName, which we hope to be more rare in NewDot.
melvin-bot commentedon May 10, 2024
@trjExpensify, @Gonals Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-][QAB] Update the QAB for `Pay someone` to be `Pay %firstName%` instead[/-][+][HOLD for payment 2024-05-20] [QAB] Update the QAB for `Pay someone` to be `Pay %firstName%` instead[/+]melvin-bot commentedon May 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-05-20. 🎊
melvin-bot commentedon May 13, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon May 13, 2024
Deployed to prod, no regression test needed as we've added one already. We also don't need to pay anyone eternal out. Closing!