You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-13] [$250] Pay someone - Add receipt placeholder is shown when receipt is not allowed when paying someone #41489
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@trjExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Activity
melvin-bot commentedon May 2, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 2, 2024
Triggered auto assignment to @MariaHCD (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon May 2, 2024
@trjExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon May 2, 2024
We think this issue might be related to the #collect project.
izarutskaya commentedon May 2, 2024
Production
Recording.2418.mp4
Nodebrute commentedon May 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add receipt placeholder is shown when receipt is not allowed when paying someone
What is the root cause of that problem?
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 331 in 20bd114
What changes do you think we should make in order to solve the problem?
We can get the type from parentReportAction which is pay in this case and use it here
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 331 in 20bd114
We can also create a utility function for future cases.
Pseudocode
We should also add this check here
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 339 to 344 in 20bd114
We can hide the above part (total + separator) to make the view similar to invoices
What alternative solutions did you explore? (Optional)
41 remaining items
melvin-bot commentedon Jun 13, 2024
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
Krishna2323 commentedon Jun 17, 2024
@trjExpensify, bump for payments.
melvin-bot commentedon Jun 17, 2024
@MariaHCD, @trjExpensify, @sobitneupane, @Krishna2323 Huh... This is 4 days overdue. Who can take care of this?
trjExpensify commentedon Jun 18, 2024
Apols, I've been OoO. Payment summary as follows:
@sobitneupane go ahead and request, @Krishna2323 I've sent you an offer.
Krishna2323 commentedon Jun 18, 2024
@trjExpensify accepted, thanks.
trjExpensify commentedon Jun 18, 2024
Paid!
sobitneupane commentedon Jun 20, 2024
Regression Test Proposal:
Do we agree 👍 or 👎
JmillsExpensify commentedon Jun 22, 2024
$250 approved for @sobitneupane. Reopeninf for the decision on the regression test.
trjExpensify commentedon Jun 24, 2024
Regression test created, closing again.