Skip to content

[HOLD for payment 2024-06-13] [$250] Pay someone - Add receipt placeholder is shown when receipt is not allowed when paying someone #41489

Closed

Description

@izarutskaya
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 2, 2024
  2. melvin-bot commented on May 2, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 2, 2024

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on May 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on May 2, 2024

    @izarutskaya
    Author

    @trjExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on May 2, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on May 2, 2024

    @izarutskaya
    Author

    Production

    Recording.2418.mp4
  8. Nodebrute commented on May 2, 2024

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add receipt placeholder is shown when receipt is not allowed when paying someone

    What is the root cause of that problem?

    const shouldShowReceiptEmptyState = !hasReceipt && !isInvoice && (canEditReceipt || isAdmin || isApprover);

    What changes do you think we should make in order to solve the problem?

    We can get the type from parentReportAction which is pay in this case and use it here

    const shouldShowReceiptEmptyState = !hasReceipt && !isInvoice && (canEditReceipt || isAdmin || isApprover);

    We can also create a utility function for future cases.
    Pseudocode

     const isPay = parentReportAction?.originalMessage?.type === 'pay'
     const shouldShowReceiptEmptyState = !isPay && !hasReceipt && !isInvoice && (canEditReceipt || isAdmin || isApprover);
    
    

    We should also add this check here

    {!isInvoice && (
    <ReceiptAuditHeader
    notes={noticeTypeViolations}
    shouldShowAuditMessage={Boolean(shouldShowNotesViolations && didRceiptScanSucceed)}
    />
    )}

    We can hide the above part (total + separator) to make the view similar to invoices

    What alternative solutions did you explore? (Optional)

  9. 41 remaining items

  10. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. Krishna2323 commented on Jun 17, 2024

    @Krishna2323
    Contributor

    @trjExpensify, bump for payments.

  12. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    @MariaHCD, @trjExpensify, @sobitneupane, @Krishna2323 Huh... This is 4 days overdue. Who can take care of this?

  13. trjExpensify commented on Jun 18, 2024

    @trjExpensify
    Contributor

    Apols, I've been OoO. Payment summary as follows:

    @sobitneupane go ahead and request, @Krishna2323 I've sent you an offer.

  14. Krishna2323 commented on Jun 18, 2024

    @Krishna2323
    Contributor

    @trjExpensify accepted, thanks.

  15. trjExpensify commented on Jun 18, 2024

    @trjExpensify
    Contributor

    Paid!

  16. sobitneupane commented on Jun 20, 2024

    @sobitneupane
    Contributor

    Regression Test Proposal:

    1. Go to FAB > Pay someone > Enter amount > Select user > Submit
    2. Open the paid IOU request > Verify Add receipt placeholder is not shown
    3. Open any paid or approved IOU report in paid policy that doesn't have any receipt
    4. Verify Add receipt placeholder is not shown

    Do we agree 👍 or 👎

  17. JmillsExpensify commented on Jun 22, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @sobitneupane. Reopeninf for the decision on the regression test.

  18. trjExpensify commented on Jun 24, 2024

    @trjExpensify
    Contributor

    Regression test created, closing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions