[HOLD for payment 2024-05-22] [CRITICAL] [VIP-Travel] Workspace - Unable to select country in Company address

@anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings
Click Company address
Without entering address first, click Country
Select a country

Expected Result:

The country is selected

Actual Result:

The country is not selected. It shows the error "This field is required"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6468902_1714658282392.address.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@anmurali

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message appears upon selecting a country

What is the root cause of that problem?

After selecting a country from the country screen, we store this value in route, but fail to update the corresponding field because we don't invoke handleAddressChange.

What changes do you think we should make in order to solve the problem?

Within the WorkspaceProfileAddressPage, we need to incorporate logic that automatically updates both the country and state fields upon selection similar to what we implemented in the AddressPage

const countryFromUrlTemp = route?.params?.country;

    // Check if country is valid
    const countryFromUrl = CONST.ALL_COUNTRIES[countryFromUrlTemp as keyof typeof CONST.ALL_COUNTRIES] ? countryFromUrlTemp : '';
    const stateFromUrl = useGeographicalStateFromRoute();
   
    useEffect(() => {
        if (!countryFromUrl) {
            return;
        }
        handleAddressChange(countryFromUrl, 'country');
    }, [countryFromUrl, handleAddressChange]);

    useEffect(() => {
        if (!stateFromUrl) {
            return;
        }
        handleAddressChange(stateFromUrl, 'state');
    }, [handleAddressChange, stateFromUrl]);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@rlinoz

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@smelaa

This is related to a new feature coming from this PR #38381

cc: @smelaa @shubham1206agra

@s77rt

@s77rt reviewed the PR

@s77rt

Payment Summary

Upwork Job

ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)
Contributor: @smelaa is from an agency-contributor and not due payment

BugZero Checklist (@anmurali)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@rlinoz

@rlinoz, @anmurali, @s77rt, @smelaa Eep! 4 days overdue now. Issues have feelings too...

@anmurali

friendly bump @anmurali

@rlinoz

@rlinoz, @anmurali, @s77rt, @smelaa 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@s77rt

@s77rt - offer is here

@anmurali

@anmurali Accepted! Thanks!

@rlinoz

@rlinoz, @anmurali, @s77rt, @smelaa Whoops! This issue is 2 days overdue. Let's get this updated quick!

@rlinoz

@rlinoz, @anmurali, @s77rt, @smelaa Still overdue 6 days?! Let's take care of this!

Paid.

Navigation Menu

Repository navigation

[HOLD for payment 2024-05-22] [CRITICAL] [VIP-Travel] Workspace - Unable to select country in Company address #41505

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

32 remaining items

Payment Summary

BugZero Checklist (@anmurali)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-05-22] [CRITICAL] [VIP-Travel] Workspace - Unable to select country in Company address #41505

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 2, 2024

lanitochka17 commented on May 2, 2024

lanitochka17 commented on May 2, 2024

cretadn22 commented on May 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 2, 2024

github-actions commented on May 2, 2024

rlinoz commented on May 2, 2024

32 remaining items

rlinoz commented on May 21, 2024

melvin-bot commented on May 22, 2024

Payment Summary

BugZero Checklist (@anmurali)

melvin-bot commented on May 27, 2024

rlinoz commented on May 28, 2024

melvin-bot commented on May 31, 2024

anmurali commented on Jun 4, 2024

s77rt commented on Jun 4, 2024

melvin-bot commented on Jun 7, 2024

melvin-bot commented on Jun 11, 2024

anmurali commented on Jun 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions