[Wave Collect] [Xero] Fix the ConnectionLayout component

Problem

The ConnectionLayout component has some extra padding issues which prevent other PRs from reusing it.

Please see discussion here.

Solution

Let's fix the component and refactor the other Xero PRs to use it.

Taking a look 👀

@carlosmiceli

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@lakchote

Hey @lakchote, sorry to bother you, but do I need to do something here?It seems reviewed and merged, right?

@lakchote

Hey @lakchote, sorry to bother you, but do I need to do something here?It seems reviewed and merged, right?

Hi @carlosmiceli, yes nothing to do on your part here! You shouldn't have been assigned, I'm correcting the assignees list.

Also, not a blocker #41754 (comment)

@abekkala

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@hungvu193

Payment Summary

Upwork Job

ROLE: @hungvu193 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@lakchote

@lakchote
I'm assuming Melvin is wrong, and payments are not actually due for anyone?

comment:

These are just follow-up clean ups/regressions fixes. No payments due here, in my opinion.

@lakchote

Yeah, no payment needed here

@lakchote I'm assuming Melvin is wrong, and payments are not actually due for anyone?

comment:

These are just follow-up clean ups/regressions fixes. No payments due here, in my opinion.

@lakchote

@lakchote I'm assuming Melvin is wrong, and payments are not actually due for anyone?

Yes, as @hungvu193 just said above, no payment is due here. Thank you!

@hungvu193

@hungvu193, @lakchote Whoops! This issue is 2 days overdue. Let's get this updated quick!

Closing the issue, no payment due.

Navigation Menu

Repository navigation

[Wave Collect] [Xero] Fix the ConnectionLayout component #41560

13 remaining items

Payment Summary

BugZero Checklist (@abekkala)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Wave Collect] [Xero] Fix the ConnectionLayout component #41560

Description

Activity

hungvu193 commented on May 3, 2024

melvin-bot commented on May 3, 2024

melvin-bot commented on May 7, 2024

carlosmiceli commented on May 7, 2024

lakchote commented on May 8, 2024

13 remaining items

melvin-bot commented on May 20, 2024

melvin-bot commented on May 20, 2024

Payment Summary

BugZero Checklist (@abekkala)

abekkala commented on May 20, 2024

hungvu193 commented on May 21, 2024

lakchote commented on May 21, 2024

melvin-bot commented on May 24, 2024

lakchote commented on May 27, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions