[HOLD for payment 2024-06-13] [$250] Distance rate can be deleted from 3-dot menu when there is only one rate

@sobitneupane

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

Precondition:

There is only one default distance rate in the workspace.

Go to staging.new.expensify.com
Go to Account settings > Workspaces > any workspace.
Go to Distance rates.
Go offline.
Add a distance rate,
Delete the default workspace rate (not the newly-added rate).
Click on the checkbox of the newly added distance rate.
Select Delete option from the dropdown.
Note that the distance rate cannot be deleted because there must be at least one distance rate.
Click on the distance rate row.
Delete it from the three-dot menu.

Expected Result:

App will show the same pop-up in Step 9 that the distance rate cannot be deleted as there is only one distance rate.

Actual Result:

Distance rate can be deleted from 3-dot menu when there is only one distance rate.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6470164_1714748306876.bandicam_2024-05-03_22-51-33-950.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0144c3fd2f5960b3c2
Upwork Job ID: 1786441064248098816
Last Price Increase: 2024-05-03
Automatic offers:

cretadn22 | Contributor | 0

Issue Owner

Current Issue Owner: @sobitneupane / @kevinksullivan

@slafortune

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@slafortune

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Job added to Upwork: https://www.upwork.com/jobs/~0144c3fd2f5960b3c2

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate can be deleted from 3-dot menu when there is only one rate

What is the root cause of that problem?

The condition canDeleteRate isn't correct.

App/src/pages/workspace/distanceRates/PolicyDistanceRateDetailsPage.tsx

Lines 50 to 51 in 75b3863

    
           const canDeleteRate = Object.values(customUnit.rates).filter((distanceRate) => distanceRate.enabled).length > 1 || !rate.enabled; 
        
           const canDisableRate = Object.values(customUnit.rates).filter((distanceRate) => distanceRate.enabled).length > 1;

What changes do you think we should make in order to solve the problem?

Remove || !rate.enabled check because user should not be able to delete the receipt until there is one more rate with enabled state. Also, I think we should canDeleteRate and canDisableRate filter out the rates that has pending action value delete. We might also want to filter out the rates with pending action value add. If we are going to filter out rates with pending action value add then we would also need to update that in PolicyDistanceRatesPage.

Optionally, we can filter out as stated above without removing || !rate.enabled check

Also check for other policy pages that has similar functionality

What alternative solutions did you explore? (Optional)

Only change the canDisableRate condition to exclude the rates with pending action delete and also add if needed.

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune / @kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@cretadn22

@cretadn22 Paid ✔️
@sobitneupane can you please complete the checklist?

@tgolen

@tgolen, @slafortune, @sobitneupane, @cretadn22 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@sobitneupane

bump @sobitneupane to complete the checklist, please.

Regression Test Proposal

Precondition: There is only one default distance rate in the workspace.

Go to Settings > Workspaces > any workspace.
Go to Distance rates.
Go offline.
Add a distance rate,
Delete the default workspace rate (not the newly-added rate).
Click on the checkbox of the newly added distance rate.
Select Delete option from the dropdown.
Verify that the distance rate cannot be deleted because there must be at least one distance rate.
Click on the distance rate row.
Delete it from the three-dot menu.
Verify that the distance rate cannot be deleted because there must be at least one distance rate.

Do we agree 👍 or 👎

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#38237

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#38237 (comment)

[@sobitneupane] Determine if we should create a regression test for this bug.

yes

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#41594 (comment)

@sobitneupane

@sobitneupane C+ is due $250 via NewDot

@sobitneupane

$250 approved for @sobitneupane

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-13] [$250] Distance rate can be deleted from 3-dot menu when there is only one rate #41594

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

47 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const canDeleteRate = Object.values(customUnit.rates).filter((distanceRate) => distanceRate.enabled).length > 1 \|\| !rate.enabled;
	const canDisableRate = Object.values(customUnit.rates).filter((distanceRate) => distanceRate.enabled).length > 1;

[HOLD for payment 2024-06-13] [$250] Distance rate can be deleted from 3-dot menu when there is only one rate #41594

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 3, 2024

m-natarajan commented on May 3, 2024

m-natarajan commented on May 3, 2024

melvin-bot commented on May 3, 2024

melvin-bot commented on May 3, 2024

Krishna2323 commented on May 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

47 remaining items

melvin-bot commented on Jun 6, 2024

slafortune commented on Jun 13, 2024

melvin-bot commented on Jun 17, 2024

tgolen commented on Jun 19, 2024

sobitneupane commented on Jun 20, 2024

sobitneupane commented on Jun 20, 2024

slafortune commented on Jun 20, 2024

JmillsExpensify commented on Jun 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions