[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Optimistic map missing when tracking distance expense

@neil-marcellini

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714782868884039

Action Performed:

Go to a workspace chat
Delete any existing tracked expenses if needed
Click plus and track expense
Choose distance, enter waypoints, Next, Track Expense

Expected Result:

Expense appears optimistically showing a map, the amount, and the merchant with distance info. After the response the same thing should be shown, although the map is expected to be slightly different.

Actual Result:

Expense appears optimistically showing the amount and the merchant with distance info only, no map. After the response it displays correctly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Screen.Recording.2024-06-26.at.8.43.14.AM.mov

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017f6ca9bb1a7123b8
Upwork Job ID: 1787504876858716160
Last Price Increase: 2024-06-10

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @JmillsExpensify

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@JmillsExpensify

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report preview doesn't show distance merchant for tracked workspace expense

What is the root cause of that problem?

The description/merchant is only shown when numberOfRequests is 1 and buildOptimisticReportPreview returns 1 for childMoneyRequestCount, but when we get data from backend the childMoneyRequestCount is again set to 0.

App/src/libs/ReportUtils.ts

Line 4074 in ab1e924

childMoneyRequestCount: 1,

App/src/components/ReportActionItem/ReportPreview.tsx

Line 123 in ab1e924

const numberOfRequests = ReportActionUtils.getNumberOfMoneyRequests(action);

App/src/components/ReportActionItem/ReportPreview.tsx

Line 142 in ab1e924

    
           let formattedMerchant = numberOfRequests === 1 ? TransactionUtils.getMerchant(allTransactions[0]) : null;

The map shouldn't be shown optimistically instead ReceiptGeneric should be shown. This is also what we do when we create submit expense distance request but the ReceiptGeneric also isn't shown because we haven't included in optimistic transaction.

App/src/libs/actions/IOU.ts

Lines 2027 to 2044 in ab1e924

    
           let optimisticTransaction = TransactionUtils.buildOptimisticTransaction( 
        
               ReportUtils.isExpenseReport(iouReport) ? -amount : amount, 
        
               currency, 
        
               shouldUseMoneyReport && iouReport ? iouReport.reportID : '0', 
        
               comment, 
        
               created, 
        
               '', 
        
               '', 
        
               merchant, 
        
               receiptObject, 
        
               filename, 
        
               existingTransactionID ?? null, 
        
               category, 
        
               tag, 
        
               billable, 
        
               isDistanceRequest ? {waypoints: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD} : undefined, 
        
               false, 
        
           );

What changes do you think we should make in order to solve the problem?

We can check for number of transaction(allTransactions.length) instead of numberOfRequests (money request) to show/hide the merchant/description and for the receipt we need to pass optimisticReceipt instead of receiptObject when isDistanceRequest is true.

   // getTrackExpenseInformation util function changes
    const optimisticReceipt: Receipt = {
        source: ReceiptGeneric as ReceiptSource,
        state: CONST.IOU.RECEIPT_STATE.OPEN,
    };
    const existingTransaction = allTransactionDrafts[`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${existingTransactionID ?? CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`];
    const isDistanceRequest = existingTransaction && existingTransaction.iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE;
    let optimisticTransaction = TransactionUtils.buildOptimisticTransaction(
        ReportUtils.isExpenseReport(iouReport) ? -amount : amount,
        currency,
        shouldUseMoneyReport && iouReport ? iouReport.reportID : '0',
        comment,
        created,
        '',
        '',
        merchant,
        isDistanceRequest ? optimisticReceipt : receiptObject,
        filename,
        existingTransactionID ?? null,
        category,
        tag,
        billable,
        isDistanceRequest ? {waypoints: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD} : undefined,
        false,
    );
    
    // In ReportPreview.tsx
    const allTransactions = TransactionUtils.getAllReportTransactions(iouReportID);
    const numberOfRequests = allTransactions.length;

What alternative solutions did you explore? (Optional)

Result

report_preview_track_expense.mp4

Job added to Upwork: https://www.upwork.com/jobs/~017f6ca9bb1a7123b8

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Show optimistic distance receipt for tracked expenses #44489

If no regressions arise, payment will be issued on 2024-07-22. 🎊

@neil-marcellini

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@neil-marcellini] The PR that introduced the bug has been identified. Link to the PR:
[@neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@neil-marcellini] Determine if we should create a regression test for this bug.
[@neil-marcellini] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@JmillsExpensify

@JmillsExpensify, @neil-marcellini 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@JmillsExpensify

@JmillsExpensify, @neil-marcellini 12 days overdue now... This issue's end is nigh!

@JmillsExpensify

This issue has not been updated in over 14 days. @JmillsExpensify, @neil-marcellini eroding to Weekly issue.

It looks like the PR was never C+ reviewed so I don't believe that any payment is due. Closing.

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Optimistic map missing when tracking distance expense #41653

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

80 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	let optimisticTransaction = TransactionUtils.buildOptimisticTransaction(
	ReportUtils.isExpenseReport(iouReport) ? -amount : amount,
	currency,
	shouldUseMoneyReport && iouReport ? iouReport.reportID : '0',
	comment,
	created,
	'',
	'',
	merchant,
	receiptObject,
	filename,
	existingTransactionID ?? null,
	category,
	tag,
	billable,
	isDistanceRequest ? {waypoints: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD} : undefined,
	false,
	);

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Optimistic map missing when tracking distance expense #41653

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 5, 2024

melvin-bot commented on May 5, 2024

Krishna2323 commented on May 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

melvin-bot commented on May 6, 2024

80 remaining items

melvin-bot commented on Jul 15, 2024

melvin-bot commented on Jul 15, 2024

melvin-bot commented on Jul 22, 2024

melvin-bot commented on Jul 23, 2024

melvin-bot commented on Jul 30, 2024

melvin-bot commented on Aug 1, 2024

JmillsExpensify commented on Aug 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions