You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-13] [$250] Last message text are not shown when searching for the rooms #41816
Please re-state the problem that we are trying to solve in this issue.
Last message text are not shown when searching for the rooms
What is the root cause of that problem?
On the function getAlternateText part of OptionsListUtils
we have a condition between if we should display option.lastMessageText or option.subtitle for chat room
If we change forcePolicyNamePreview to false from getSearchOptions or remove it, this will effect also the Policy Expense Chat preview on the find page
POC;
What alternative solutions did you explore? (Optional)
changed the title [-]Last message text are not shown when searching for the rooms[/-][+][$250] Last message text are not shown when searching for the rooms[/+]on May 9, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rushatgabhane] Determine if we should create a regression test for this bug.
[@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: This is a new behavior. Not a bug.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
1. Go to any room chat
2. Send a comment
3. Click on the search icon from LHN
4. Verify that the last posted comment is displayed under the room name in search page
Activity
melvin-bot commentedon May 7, 2024
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon May 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Showing the workspace chat name as last comment
What is the root cause of that problem?
In
getSearchOptions, we passforcePolicyNamePreviewastrueintogetOptionsfunctionApp/src/libs/OptionsListUtils.ts
Line 1996 in 55c56bf
So the alternateText is forced to the
policyNameby this conditionApp/src/libs/OptionsListUtils.ts
Line 556 in 55c56bf
What changes do you think we should make in order to solve the problem?
We should remove param so it can have the default value is
falseand then the last message text is shown in search pageApp/src/libs/OptionsListUtils.ts
Line 1996 in 55c56bf
What alternative solutions did you explore? (Optional)
NA
Result
dragnoir commentedon May 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Last message text are not shown when searching for the rooms
What is the root cause of that problem?
On the function
getAlternateTextpart ofOptionsListUtilswe have a condition between if we should display
option.lastMessageTextoroption.subtitlefor chat roomApp/src/libs/OptionsListUtils.ts
Lines 555 to 557 in 55c56bf
because
forcePolicyNamePreviewis always true, the condition goes tooption.subtitleWhat changes do you think we should make in order to solve the problem?
We should create a seperate condition for the chat room
If we change forcePolicyNamePreview to false from getSearchOptions or remove it, this will effect also the Policy Expense Chat preview on the find page
POC;
What alternative solutions did you explore? (Optional)
NA
laurenreidexpensify commentedon May 8, 2024
@youssef-lr is this under vip-vsb?
youssef-lr commentedon May 8, 2024
@laurenreidexpensify Yes I think it fits there.
[-]Last message text are not shown when searching for the rooms[/-][+][$250] Last message text are not shown when searching for the rooms[/+]melvin-bot commentedon May 9, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d5ae7362185c5a44
melvin-bot commentedon May 9, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)34 remaining items
melvin-bot commentedon Jun 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
laurenreidexpensify commentedon Jun 13, 2024
Payment Summary -
@rushatgabhane pls confirm regression steps and checklist thanks
melvin-bot commentedon Jun 13, 2024
Payment Summary
Upwork Job
BugZero Checklist (@laurenreidexpensify)
laurenreidexpensify commentedon Jun 14, 2024
@rushatgabhane pls confirm regression steps and checklist above so we can close thanks
rushatgabhane commentedon Jun 16, 2024
The PR that introduced the bug has been identified. Link to the PR: This is a new behavior. Not a bug.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
JmillsExpensify commentedon Jun 23, 2024
@mallenexpensify can you please confirm the payment summary about with an amount for @rushatgabhane? I can't approve until I have that.
mallenexpensify commentedon Jun 24, 2024
@JmillsExpensify , updated Lauren's payment breakdown above
JmillsExpensify commentedon Jun 25, 2024
$250 approved for @rushatgabhane