Skip to content

[$250] [HOLD for payment 2024-05-22] Category - Unable to select disabled category with keyboard #41890

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.72-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Submit an expense with category to the workspace chat.
  3. Disable the category used in Step 2 in workspace settings
  4. Return to transaction thread.
  5. Click Category.
  6. Navigate through the list with keyboard arrow.

Expected Result:

User should be able to select the disabled category with keyboard since the disabled category is still interactable with cursor.

Actual Result:

User is unable to select the disabled category with keyboard when the disabled category is still interactable with cursor.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6475577_1715238037078.bandicam_2024-05-09_14-54-02-272.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015f6e63bca303a149
  • Upwork Job ID: 1793342428448505856
  • Last Price Increase: 2024-05-22
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 9, 2024
  2. melvin-bot commented on May 9, 2024

    @melvin-bot

    Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on May 9, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on May 9, 2024

    @melvin-bot

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

    1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
      • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
    2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
      • You can adjust the urgency of the issue to better represent the gravity of the bug.
      • If the issue is super low priority, feel free to un-assign yourself.
      • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
      • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

    Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

  5. 28 remaining items

  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 22, 2024
  7. melvin-bot commented on May 22, 2024

    @melvin-bot

    Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 22, 2024
  9. melvin-bot commented on May 22, 2024

    @melvin-bot
  10. changed the title [-][HOLD for payment 2024-05-22] Category - Unable to select disabled category with keyboard[/-] [+][$250] [HOLD for payment 2024-05-22] Category - Unable to select disabled category with keyboard[/+] on May 22, 2024
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 22, 2024
  12. melvin-bot commented on May 22, 2024

    @melvin-bot

    Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

  13. mallenexpensify commented on May 22, 2024

    @mallenexpensify
    Contributor

    Interesting, it's possible that an Upwork job can't be created if the Awaiting Payment label is added (or... there was just a glitch earlier with creating a job and it then it worked a few mins later.

    @Krishna2323 @alitoshmatov , can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~015f6e63bca303a149

  14. Krishna2323 commented on May 22, 2024

    @Krishna2323
    Contributor

    @mallenexpensify, sorry for inconvenience, this doesn't require payments, it was a regression from my PR.

  15. mallenexpensify commented on May 22, 2024

    @mallenexpensify
    Contributor

    ah... thanks @Krishna2323 (I got a ping payment was due and wanted to be usre I wasn't late, should have read/reviewed the details). Closing then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions