You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-06] [$250] preDeploy.yml should not skip on default branch if another run is queued #41936
This was caused by this PR. We don't want to revert this PR because it saves resources on builds for pull requests, we just don't want it to apply to when we're merging into main.
changed the title [-]`preDeploy.yml` should not skip on default branch if another run is queued[/-][+][$250] `preDeploy.yml` should not skip on default branch if another run is queued[/+]on May 9, 2024
Proposal:
Please re-state the problem that we are trying to solve in this issue.
The problem we are trying to solve is that when multiple pull requests are merged into the main branch in quick succession, the workflow runs triggered by earlier merges are being canceled due to the cancel-in-progress: true flag in the workflow concurrency configuration.
What is the root cause of that problem?
The root cause of the problem is the cancel-in-progress: true setting, which is designed to cancel any currently running workflows or jobs with the same concurrency group when a new workflow run is triggered. This behavior is desirable for pull requests, where we want to save resources and avoid running redundant workflows or jobs when a new commit is pushed. However, for merges into the main branch, we want all workflow runs to complete without being canceled, even if another merge happens shortly after.
What changes do you think we should make in order to solve the problem?
To solve the problem, we can introduce conditional logic in the workflow files to apply the cancel-in-progress: true setting only for pull requests and not for merges to the main branch.
For the preDeploy.yml workflow file (or any other workflow file that handles merges to the main branch), we can set the cancel-in-progress setting to false
What alternative solutions did you explore? (Optional)
An alternative solution could be to introduce a delay or a manual trigger for workflow runs triggered by merges to the main branch. This would prevent the second workflow run from canceling the first one, but it might introduce additional complexity or manual intervention in the deployment process.
Activity
melvin-bot commentedon May 9, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (
External)melvin-bot commentedon May 9, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]`preDeploy.yml` should not skip on default branch if another run is queued[/-][+][$250] `preDeploy.yml` should not skip on default branch if another run is queued[/+]melvin-bot commentedon May 9, 2024
Job added to Upwork: https://www.upwork.com/jobs/~013f9368ae63177d49
melvin-bot commentedon May 9, 2024
Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.
amgenene commentedon May 9, 2024
Proposal:
Please re-state the problem that we are trying to solve in this issue.
The problem we are trying to solve is that when multiple pull requests are merged into the main branch in quick succession, the workflow runs triggered by earlier merges are being canceled due to the cancel-in-progress: true flag in the workflow concurrency configuration.
What is the root cause of that problem?
The root cause of the problem is the cancel-in-progress: true setting, which is designed to cancel any currently running workflows or jobs with the same concurrency group when a new workflow run is triggered. This behavior is desirable for pull requests, where we want to save resources and avoid running redundant workflows or jobs when a new commit is pushed. However, for merges into the main branch, we want all workflow runs to complete without being canceled, even if another merge happens shortly after.
What changes do you think we should make in order to solve the problem?
To solve the problem, we can introduce conditional logic in the workflow files to apply the cancel-in-progress: true setting only for pull requests and not for merges to the main branch.
For the preDeploy.yml workflow file (or any other workflow file that handles merges to the main branch), we can set the cancel-in-progress setting to false
What alternative solutions did you explore? (Optional)
An alternative solution could be to introduce a delay or a manual trigger for workflow runs triggered by merges to the main branch. This would prevent the second workflow run from canceling the first one, but it might introduce additional complexity or manual intervention in the deployment process.
37 remaining items
melvin-bot commentedon May 30, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bfitzexpensify commentedon May 30, 2024
Adding a BZ buddy for payment/regression test update - I will be OOO until June 11th
rayane-d commentedon Jun 5, 2024
This doesn't need a BZ checklist as it's a Github action improvement
garrettmknight commentedon Jun 6, 2024
All paid out, closing!
Qualify the Bun tests concurrency group by SHA on main