Repository navigation
[HOLD for payment 2024-05-22] Tax - Unable to save valid tax rate amount when changing currency for the first time #42047
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team
Action Performed:
Precondition:
- Workspace has enabled tax rate.
- Workspace currency default is tax exempt (0%).
- Foreign currency default have different tax rate (non-zero rate).
- Go to staging.new.expensify.com
- Go to workspace chat.
- Go to + > Submit expense.
- Enter amount (maintain local currency) > Next.
- On confirmation page, click Tax amount.
- Change the currency to any foreign currency.
- After changing to foreign currency, the tax rate will automatically adjust to the non-zero tax rate (Foreign currency default).
- Enter a valid tax amount (now that the rate is no longer 0%).
- Save it.
Expected Result:
User will be able to save the tax amount as long as the tax amount falls within the limit of the new rate (Foreign currency default).
Actual Result:
When saving a valid tax amount, error shows up. The maximum rate amount in the error message still follows the previous tax rate (Workspace currency default). User will need to save 0 tax amount and return to Tax amount after saving to save the new tax amount.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon May 13, 2024
Triggered auto assignment to @lakchote (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 13, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 13, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
39 remaining items
strepanier03 commentedon May 23, 2024
I hired your in Upwork @ShridharGoel, I'll check tomorrow to see if I can pay it out.
@allroundexperts - I'll finish up the payment summary once the checklist is done, thanks!
allroundexperts commentedon May 26, 2024
Checklist
strepanier03 commentedon May 28, 2024
Payment Summary
@JmillsExpensify - Payment request incoming.
strepanier03 commentedon Jun 2, 2024
@ShridharGoel - Please accept the Upwork job so it can be paid?
strepanier03 commentedon Jun 2, 2024
I am out of the office from June 3-10 - If you need BZ action in that time please reach out in Slack to ask for an assist.
JmillsExpensify commentedon Jun 5, 2024
Contributor paid out. @allroundexperts going to close this issue and see you again when I receive the payment request.
JmillsExpensify commentedon Jul 9, 2024
$250 approved for @allroundexperts