You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web - Settings - Dropdown symbol overlaps with text in the box #4207
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@robertjchen Generally issues labelled DeployBlockerCash should be treated as internal. In this case, since @parasharrajat has already tracked the source of the regression to #4180, I think we should just revert it, giving @helaoutar a chance to retry the PR without causing a regression.
Activity
OSBotify commentedon Jul 24, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Jul 24, 2021
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.parasharrajat commentedon Jul 24, 2021
it is a regression.
robertjchen commentedon Jul 26, 2021
I was able to reproduce this myself- seems like a visual issue, assigning to
Externalfor resolution.MelvinBot commentedon Jul 26, 2021
Triggered auto assignment to @JmillsExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.parasharrajat commentedon Jul 26, 2021
@robertjchen. This is a regression from #4180.
Root cause.
40f145e
roryabraham commentedon Jul 26, 2021
@robertjchen Generally issues labelled
DeployBlockerCashshould be treated as internal. In this case, since @parasharrajat has already tracked the source of the regression to #4180, I think we should just revert it, giving @helaoutar a chance to retry the PR without causing a regression.roryabraham commentedon Jul 27, 2021
Revert PR here
roryabraham commentedon Jul 27, 2021
@helaoutar fixed this in this PR, so I closed the revert PR.
roryabraham commentedon Jul 28, 2021
@isagoico, I see you checked this off on the deploy checklist so I'm assuming this is fix is verified. Closing this out :)
isagoico commentedon Jul 28, 2021
Yep! I thought I had left a comment here. I retested and it was a pass 🎉