You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Split - No spacing between username + email address and split amount on confirmation page #42191
Version Number: 1.4.74-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
User has long email address
Go to staging.new.expensify.com
Open a chat with user that also has long email address
Click + > Split expense
Enter amount > Next
Expected Result:
There should be some spacing between username + email address and the split amount (production behavior) on the confirmation page
Actual Result:
There is no spacing between username + email address and the split amount on the confirmation page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Split - No spacing between username + email address and split amount on confirmation page[/-][+][$250] Split - No spacing between username + email address and split amount on confirmation page[/+]on May 15, 2024
Activity
melvin-bot commentedon May 15, 2024
Triggered auto assignment to @danieldoglas (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 15, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 15, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon May 15, 2024
@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon May 15, 2024
We think that this bug might be related to #vip-split
srikarparsi commentedon May 15, 2024
This does look external, adding the label
[-]Split - No spacing between username + email address and split amount on confirmation page[/-][+][$250] Split - No spacing between username + email address and split amount on confirmation page[/+]melvin-bot commentedon May 15, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01b8b1885e9bbd36c6
7 remaining items
melvin-bot commentedon May 21, 2024
@danieldoglas, @allroundexperts, @srikarparsi Eep! 4 days overdue now. Issues have feelings too...
srikarparsi commentedon May 21, 2024
Still waiting on the merge freeze for this PR to hit staging. Removing overdue label
srikarparsi commentedon May 23, 2024
The PR hit staging and it looks good now. Closing this out.