Skip to content

[HOLD for payment 2024-06-03] [$125] Web - Split scan - Excessive header space in split menu #42210

New issue
New issue
Closed
Closed
[HOLD for payment 2024-06-03] [$125] Web - Split scan - Excessive header space in split menu#42210
Assignees
pecanororushatgabhaneisabelastissernkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Description

@kavimuru
kavimuru
opened on May 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to https://42057.pr-testing.expensify.com/
  2. Go to any chat.
  3. Go to + > Split expense.
  4. Split a scan expense.
  5. Click on the split preview.

Expected Result:

There will be no excessive space in the split header.

Actual Result:

There is excessive space in the split header.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
330498684-8c5d696b-f3b7-49f0-a191-310d79c3be21

330498731-982b81cc-4e9e-4ec1-b02b-f7a5da2de41e.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bb522a9c968afba5
  • Upwork Job ID: 1791118490892976128
  • Last Price Increase: 2024-05-16
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. kavimuru
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 15, 2024
  2. melvin-bot
    assigned
    arosiclair
    on May 15, 2024
  3. melvin-bot
    added
    Engineering
    HourlyKSv2
    on May 15, 2024

  4. melvin-bot commented on May 15, 2024

    @melvin-bot
    melvin-botBot
    on May 15, 2024 – with Melvin Bot

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

    1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
      • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
    2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
      • You can adjust the urgency of the issue to better represent the gravity of the bug.
      • If the issue is super low priority, feel free to un-assign yourself.
      • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
      • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

    Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

  5. github-actions
    removed
    DailyKSv2
    on May 15, 2024

  6. github-actions commented on May 15, 2024

    @github-actions
    github-actionsBot
    on May 15, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot
    assigned
    isabelastisser
    on May 15, 2024

  8. melvin-bot commented on May 15, 2024

    @melvin-bot
    melvin-botBot
    on May 15, 2024 – with Melvin Bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  9. melvin-bot
    added
    DailyKSv2
    and removed
    HourlyKSv2
    on May 15, 2024
  10. melvin-bot
    assigned
    pecanoro
    on May 15, 2024

  11. 37 remaining items

  12. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on May 27, 2024
  13. melvin-bot
    changed the title [-][$125] Web - Split scan - Excessive header space in split menu[/-] [+][HOLD for payment 2024-06-03] [$125] Web - Split scan - Excessive header space in split menu[/+] on May 27, 2024
  14. melvin-bot
    removed
    ReviewingHas a PR in review
    on May 27, 2024

  15. melvin-bot commented on May 27, 2024

    @melvin-bot
    melvin-botBot
    on May 27, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on May 27, 2024

    @melvin-bot
    melvin-botBot
    on May 27, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-03. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on May 27, 2024

    @melvin-bot
    melvin-botBot
    on May 27, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane] Determine if we should create a regression test for this bug.
    • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  18. rushatgabhane commented on May 30, 2024

    @rushatgabhane
    rushatgabhane
    on May 30, 2024
    Member

    1. The PR that introduced the bug has been identified. Link to the PR: fix Top and bottom borders of header status #41643

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix Top and bottom borders of header status #41643 (review)

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

    4. Determine if we should create a regression test for this bug. No because it was caught by QA and will come up easily when split flow is tested

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

  19. rushatgabhane commented on May 30, 2024

    @rushatgabhane
    rushatgabhane
    on May 30, 2024
    Member

    @isabelastisser could you please attach payment summary for this issue thank you 🙇

  20. isabelastisser commented on May 31, 2024

    @isabelastisser
    isabelastisser
    on May 31, 2024
    Contributor

    Payment summary:

    @rushatgabhane requires payment through NewDot Manual Requests. $125 C+ review PENDING
    @nkdengineer requires payment. $125 Contributor. I sent you the offer in Upwork now: https://www.upwork.com/ab/applicants/1791118490892976128/job-details

  21. nkdengineer commented on May 31, 2024

    @nkdengineer
    nkdengineer
    on May 31, 2024
    Contributor

    @isabelastisser I accepted the offer, thanks 🙇

  22. JmillsExpensify commented on May 31, 2024

    @JmillsExpensify
    JmillsExpensify
    on May 31, 2024
    Contributor

    $125 approved for @rushatgabhane

  23. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jun 2, 2024

  24. isabelastisser commented on Jun 3, 2024

    @isabelastisser
    isabelastisser
    on Jun 3, 2024
    Contributor

    All set!

  25. isabelastisser
    closed this as completedon Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions