[HOLD for payment 2024-06-06] [$250] Tags - After deleting a Tag, the select button is not showing the correct amount

@stephanieelliott

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.74-1
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #42086
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Open the New Expensify App
Sign into a valid account
Click on WS > Tags (Enable if needed)
Add a couple of tags (Two are fine)
Select the two tags (Notice it says 2 are selected)
Delete one of the tags
Add a new tag quickly so there are 2 again
Select "All" button to select both tags

Expected Result:

User expects the correct number of tags to be shown in the selected area

Actual Result:

The incorrect number of tags is shown, "3 selected" is shown instead of "2 selected"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6482146_1715817630755.Incorrect_number_of_tags_are_shown_in_selection_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010953527677d8e414
Upwork Job ID: 1791581466256613376
Last Price Increase: 2024-05-17
Automatic offers:

Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @stephanieelliott

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think this issue might be related to the #collect project.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - After deleting a Tag, the select button is not showing the correct amount

What is the root cause of that problem?

We are not filtering out tags with pending action of delete.

What changes do you think we should make in order to solve the problem?

Filter out tags with pending action of delete in toggleAllTags callback.

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 122 to 125 in 1faad15

    
           const toggleAllTags = () => { 
        
               const isAllSelected = tagList.every((tag) => !!selectedTags[tag.value]); 
        
               setSelectedTags(isAllSelected ? {} : Object.fromEntries(tagList.map((item) => [item.value, true]))); 
        
           };

We apply same logic as in WorkspaceCategoriesPage.

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 109 to 113 in 1faad15

    
           const toggleAllCategories = () => { 
        
               const availableCategories = categoryList.filter((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE); 
        
               const isAllSelected = availableCategories.length === Object.keys(selectedCategories).length; 
        
               setSelectedCategories(isAllSelected ? {} : Object.fromEntries(availableCategories.map((item) => [item.keyForList, true]))); 
        
           };

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~010953527677d8e414

@thesahindia

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - Upon removal of a tag, the select button fails to display the accurate quantity

What is the root cause of that problem?

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 122 to 125 in 1faad15

    
           const toggleAllTags = () => { 
        
               const isAllSelected = tagList.every((tag) => !!selectedTags[tag.value]); 
        
               setSelectedTags(isAllSelected ? {} : Object.fromEntries(tagList.map((item) => [item.value, true]))); 
        
           };

The toggleAllTags function does not properly filter out tags with pending delete actions. And the logic for checking isAllSelected also be wrong

What changes do you think we should make in order to solve the problem?

It's necessary to filter out tags that have pending delete actions. And then we also need to update the logic for checking isAllSelected, it's crucial to filter out tags with pending delete actions to maintain correct functionality when offline

const notPendingDeleteTag = tagList.filter((item)=> item.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE)
const isAllSelected = notPendingDeleteTag.every((tag) => !!selectedTags[tag.value]);
setSelectedTags(isAllSelected ? {} : Object.fromEntries(notPendingDeleteTag.map((item) => [item.value, true])));

The same fix should be applied to other pages as well

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal: Fix for Incorrect Tag Count After Deletion

Overview:
The current issue arises because tags pending deletion are still considered in the selection logic, leading to an incorrect tag count.

Technical Explanation:
To address this issue, I will modify the toggleAllTags function to exclude tags that have a pendingAction set to CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE.

Proposed Code Change:
The revised toggleAllTags function will look as follows:

const toggleAllTags = () => {
    const isAllSelected = tagList.every((tag) => selectedTags[tag.value] && tag.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
    setSelectedTags(isAllSelected ? {} : Object.fromEntries(tagList.filter(tag => tag.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE).map((item) => [item.value, true])));
};

Note

This update ensures that tags pending deletion are not considered when determining if all tags are selected and when toggling all tags. I recommend applying the same correction to other pages.

After changes done:

Screen.Recording.2024-05-19.at.3.14.38.AM.mov

Reviewing label has been removed, please complete the "BugZero Checklist".

@thesahindia

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Tags - After deleting a Tag, the select button is not showing the correct length. #42455

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

@thesahindia requires payment through NewDot Manual Requests
@Krishna2323 requires payment automatic offer (Contributor)

@thesahindia

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@thesahindia

Hey @thesahindia can you please complete the BZ checklist?

@Krishna2323

Summarizing payment on this issue:

Contributor: @Krishna2323 $250 via Upwork - PAID
Contributor+: @thesahindia $250 via NewDot - please request

Upwork job is here: https://www.upwork.com/jobs/~010953527677d8e414

This case should have been handled in #37621 but it was missed.

We should add a general test case for all similar instances -

Go to any page that has a list (example: Workspace tags page)
Make sure there are at least 2 list items
Click the top most checkbox to select all items
Verify it says "2 selected" at the top right corner
Go offline
Delete one item
Again select all the items
Verify it says "1 selected"

@thesahindia

Thanks @thesahindia! Issue for regression test created here: https://github.com/Expensify/Expensify/issues/402937

@thesahindia

$250 approved for @thesahindia

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-06] [$250] Tags - After deleting a Tag, the select button is not showing the correct amount #42271

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal: Fix for Incorrect Tag Count After Deletion

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const toggleAllTags = () => {
	const isAllSelected = tagList.every((tag) => !!selectedTags[tag.value]);
	setSelectedTags(isAllSelected ? {} : Object.fromEntries(tagList.map((item) => [item.value, true])));
	};

	const toggleAllCategories = () => {
	const availableCategories = categoryList.filter((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
	const isAllSelected = availableCategories.length === Object.keys(selectedCategories).length;
	setSelectedCategories(isAllSelected ? {} : Object.fromEntries(availableCategories.map((item) => [item.keyForList, true])));
	};

[HOLD for payment 2024-06-06] [$250] Tags - After deleting a Tag, the select button is not showing the correct amount #42271

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 16, 2024

izarutskaya commented on May 16, 2024

Krishna2323 commented on May 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 17, 2024

melvin-bot commented on May 17, 2024

cretadn22 commented on May 18, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

RandikaSilva commented on May 18, 2024

Proposal: Fix for Incorrect Tag Count After Deletion

22 remaining items

melvin-bot commented on May 30, 2024

melvin-bot commented on May 30, 2024

melvin-bot commented on May 30, 2024

stephanieelliott commented on Jun 4, 2024

stephanieelliott commented on Jun 4, 2024

thesahindia commented on Jun 4, 2024

stephanieelliott commented on Jun 7, 2024

JmillsExpensify commented on Jun 17, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions