Repository navigation
[HOLD for payment 2024-06-11] [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default #42466
Description
We need to remove Taxes from the LHN when we're disconnecting from Xero and we had taxes sync enabled.
Activity
[-][Wave Collect] [Xero] Disable Taxes when disconnecting[/-][+][Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't support it[/+][-][Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't support it[/-][+][Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default[/+]mountiny commentedon Jun 4, 2024
@trjExpensify based on the comment this was not fully fixed, I think we need to find someone to look into this / retest and fix if its not done yet #42467 (comment)
trjExpensify commentedon Jun 4, 2024
Cool, I can retest after the next deploy.
24 remaining items
lakchote commentedon Jul 2, 2024
I found the culprit, and pushed a PR to fix it here
cc @trjExpensify once you'll see why we weren't seeing the bug... ah 😄
trjExpensify commentedon Jul 2, 2024
Dang, nice sleuthing!
mvtglobally commentedon Jul 3, 2024
Issue is reproducible during KI retests.
lakchote commentedon Jul 8, 2024
PR to fix this is up for review.
allroundexperts commentedon Jul 8, 2024
Comment for assignment
bondydaa commentedon Jul 8, 2024
assigned @allroundexperts since they're helping to test the PR #44952
trjExpensify commentedon Jul 24, 2024
The regression period is over on this. Confirming payment summary as follows:
Go ahead and request! Closing.
JmillsExpensify commentedon Oct 4, 2024
$250 approved for @allroundexperts