You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-02] [$250] Video - Change in playback speed is not reflected in thread report #42519
Version Number: 1.4.75-0 Reproducible in staging?: Y Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A Email or phone of affected tester (no customers):natnael.expensify+3@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Navigate to a report
Send a video
Reply in a thread to the video
Navigate back to the main report
Change playback speed
Navigate to the thread report
Click on 'Three dots' > 'Playback speed'
Expected Result:
Changes in Playback speed from the main report should be reflected in the thread report
Actual Result:
Changes in playback speed from the main report is not reflected in the thread report
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@Julesssss FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Regression Test Steps
Send a video to any chat
Reply the video in thread
Navigate to parent report
Change playback speed
Navigate to thread
Open playback speed menu
Verify thread's playback speed is the same with parent's
Activity
melvin-bot commentedon May 23, 2024
Triggered auto assignment to @Julesssss (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon May 23, 2024
We think that this bug might be related to #vip-vsp
lanitochka17 commentedon May 23, 2024
@Julesssss FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Julesssss commentedon May 23, 2024
Thanks.
This should not block deploy IMO. Removing the label.
93 remaining items
tienifr commentedon Aug 5, 2024
The PR is ready for review cc @Julesssss @situchan
mallenexpensify commentedon Aug 14, 2024
In the PR I'm not seeing that it was deployed to production.
@situchan @tienifr , any idea what might be going on? I want to update the title to reflect the correct payment date
mallenexpensify commentedon Aug 17, 2024
@situchan @tienifr 👀 on the comment above plz so I can get you paid (assuming it's needed)
situchan commentedon Aug 19, 2024
There was bug on that deploy. Melvin didn't post deploy comment on all PRs in this checklist.
cc: @Beamanator
Beamanator commentedon Aug 19, 2024
Agreed 👍 I posted in the PR about it being deployed to prod here - #46800 (comment)
mallenexpensify commentedon Aug 20, 2024
d;oh, sorry, I should have seen that comment.
Contributor: @tienifr owed $250 via NewDot
Contributor+: @situchan paid $250 via NewDot.
@situchan plz complete the BZ checklist above? Thx
situchan commentedon Aug 21, 2024
Regression Test Steps
mallenexpensify commentedon Aug 26, 2024
Thanks @situchan
Test Case GH created
garrettmknight commentedon Aug 27, 2024
@tienifr paid $250 via NewDot