Skip to content

[$250] [HOLD for payment 2024-06-13] [QBO] Amend the account type available to configure on reimbursable exports to be relevant to the selected export option #42520

Closed

Description

@zanyrenney

Problem:

The copy used for reimbursable exports inconsistently refers to all selections as choosing an A/P account, instead of showing the QBO accounts that should be shown per export choice.

Additionally, the page's copy always mentions vendor bills, regardless of whether a check or journal entry is selected for export.
Lastly, we're only showing explainer text for vendor bills, meaning there is not consitency in the design as there are no similar explanations for checks or journal entries (this is different from oldDot where we use the full explainers on the export page.

Solution: Update the QBO accounts available to chosen depending on the export choice to:

Vendor Bill:
image

Notes for completeness:

  • Update copy on screen 1: Export out-of-pocket expenses as page copy should read We'll create a single itemized vendor bill for each Expensify report. If the period of the bill is closed, we'll post to the 1st of the next open period. You can add the vendor bill to your A/P account of choice (below).
  • Update the push input label depending on the export selection (in this case, Accounts Payable)
    Update copy on screen 2:
    Copy should read: "This is your chosen A/P account, against which vendor bills for each report are created."

Journal Entry:
image

Notes for completeness:

  • Update copy on screen 1: Export out-of-pocket expenses as page copy should read We'll create a single itemized journal entry for each Expensify report. You can post the offset entry to your account of choice (below).
  • Update the push input label depending on the export selection (in this case, Account)
  • Screen 2: Copy should read: "This is your chosen account to post the journal entry offset for each report."

Check:
image

Notes for completeness:

  • Update copy on screen 1: Export out-of-pocket expenses as page copy should read We'll create a single itemized check for each Expensify report. You can write the check from your bank account of choice (below).
  • Update the push input label depending on the export selection (in this case, Bank account)
  • Copy should read: "This is your chosen bank account to write checks from."
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014665d08c6cbedbca
  • Upwork Job ID: 1801670785370229018
  • Last Price Increase: 2024-06-14

Activity

  1. hunxjunedo commented on May 23, 2024

    @hunxjunedo

    kindly provide details about reproducing the issue, and the platforms which are affected by it.

  2. melvin-bot commented on May 23, 2024

    @melvin-bot

    📣 @hunxjunedo! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 23, 2024
  4. melvin-bot commented on May 23, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collecton May 23, 2024
  6. moved this from Release 1: Spring 2024 (May) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collecton May 23, 2024
  7. trjExpensify commented on May 23, 2024

    @trjExpensify
    Contributor

    Solution: Update the QBO accounts available to chosen depending on the export choice to:
    Vendor bill = accountPayableAccounts only
    Check = bankAccounts
    Journal Entry = (a few different QBO accountTypes are available here)

    @zanyrenney the account types being made available for selection are correct for each export type chosen, it's the copy, labelling and so on which is incorrect. The purpose of this was to illustrate why it's incorrect to always be referring to vendor bills and AP account selection.

  8. zanyrenney commented on May 23, 2024

    @zanyrenney
    ContributorAuthor

    I think the rest of the issue is correct though right? I'll just remove that bit, I was trying to add more context from the slack thread, but let me get that cleaned up @trjExpensify

  9. 21 remaining items

  10. changed the title [-][HOLD for payment 2024-06-13] [QBO] Amend the account type available to configure on reimbursable exports to be relevant to the selected export option[/-] [+][$250] [HOLD for payment 2024-06-13] [QBO] Amend the account type available to configure on reimbursable exports to be relevant to the selected export option[/+] on Jun 14, 2024
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 14, 2024
  12. melvin-bot commented on Jun 14, 2024

    @melvin-bot

    Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

  13. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 14, 2024
  14. zanyrenney commented on Jun 14, 2024

    @zanyrenney
    ContributorAuthor
  15. s77rt commented on Jun 14, 2024

    @s77rt
    Member

    @zanyrenney Applied!

  16. zanyrenney commented on Jun 17, 2024

    @zanyrenney
    ContributorAuthor

    hired you - with offer - please accept.

  17. s77rt commented on Jun 17, 2024

    @s77rt
    Member

    @zanyrenney Accepted! Thanks!

  18. zanyrenney commented on Jun 19, 2024

    @zanyrenney
    ContributorAuthor

    Payment Summary

    https://www.upwork.com/jobs/~014665d08c6cbedbca

    • ROLE: @s77rt paid $250 via Upwork

    BugZero Checklist (@zanyrenney)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  19. zanyrenney commented on Jun 19, 2024

    @zanyrenney
    ContributorAuthor

    all done here, thanks @s77rt

  20. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions