[$250] Room - App opens random chat after leaving public room when logging in via public room link

@ahmedGaber93

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #42020
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to staging.new.expensify.com
Log out if logged in.
Navigate to public room link.
Click Sign in on the bottom banner.
Log in with an existing account.
After login, without opening other reports, leave the public room.

Expected Result:

App will redirect to Concierge chat after leaving public room when user signs in via public room link.

Actual Result:

App redirects to a random chat after leaving public room when user signs in via public room link.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6489382_1716467277141.20240523_201414.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a7c33cc36264b58f
Upwork Job ID: 1793716819096788992
Last Price Increase: 2024-05-23

Issue Owner

Current Issue Owner: @ahmedGaber93

@danieldoglas

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@puneetlath

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
- If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
- You can adjust the urgency of the issue to better represent the gravity of the bug.
- If the issue is super low priority, feel free to un-assign yourself.
- Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
- If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

We don't handle navigate to concierge room when user leave report.

What is the root cause of that problem?

After leave room we only navigate to the most recent report

App/src/libs/actions/Report.ts

Lines 2659 to 2660 in dadc3b8

    
           API.write(WRITE_COMMANDS.LEAVE_ROOM, parameters, {optimisticData, successData, failureData}); 
        
           navigateToMostRecentReport(report);

What changes do you think we should make in order to solve the problem?

We will check the report is public room and previous route is sign-in and after leave public room we will navigate to concierge page instead of only navigate to the most recent report at this line

    API.write(WRITE_COMMANDS.LEAVE_ROOM, parameters, {optimisticData, successData, failureData});
    const isPublicRoom = ReportUtils.isPublicRoom(report);
    const previousRoute = Navigation.getPreviousRoute();
    if (isPublicRoom && previousRoute === ROUTES.SIGN_IN_MODAL) {
        navigateToConciergeChat();
    } else {
        navigateToMostRecentReport(report);
    }

POC

Screen.Recording.2024-05-24.at.00.13.43.mov

What alternative solutions did you explore? (Optional)

I don't think we need to block the deploy over this. It's a very specific scenario.

Job added to Upwork: https://www.upwork.com/jobs/~01a7c33cc36264b58f

@ahmedGaber93

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

@puneetlath

@puneetlath I think this expected, the user is redirect to last opened report not to random report and this was the expected result when we were working on #41128

#41128 expected result:

if users leave a room or group, we will redirect them to the last opened report (sort onyx reports by last read and find the last one)
if a new user open the room from deep link, so he didn't open any report yet, we will redirect them to concierge

CC @Julesssss @Nodebrute

Ah cool, thanks for letting me know. Closing this out then!

Navigation Menu

Repository navigation

[$250] Room - App opens random chat after leaving public room when logging in via public room link #42522

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

2 remaining items

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	API.write(WRITE_COMMANDS.LEAVE_ROOM, parameters, {optimisticData, successData, failureData});
	navigateToMostRecentReport(report);

[$250] Room - App opens random chat after leaving public room when logging in via public room link #42522

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 23, 2024

melvin-bot commented on May 23, 2024

melvin-bot commented on May 23, 2024

github-actions commented on May 23, 2024

2 remaining items

suneox commented on May 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

puneetlath commented on May 23, 2024

melvin-bot commented on May 23, 2024

melvin-bot commented on May 23, 2024

ahmedGaber93 commented on May 24, 2024

puneetlath commented on May 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions