Skip to content

[HOLD for payment 2024-06-13] [$250] [Xero] [QBO] Improve the empty state of pages when there are no imported accounts found  #42544

Closed

Description

@trjExpensify

Coming from here

Problem: When there’s no imported accounts found, we show an ambiguous empty page that makes it appear as though something is broken. When in fact, the page is empty because the accounts we're looking for don't exist in the accounting solution to import into Expensify.

image

Solution:
Add an illustration to the pages with an explainer to explain the lack of accounts being seen.

image

Copy

No accounts found
Add the account in and sync the connection again

Pages
/quickbooks-online/export/out-of-pocket-expense/account-select
/quickbooks-online/export/company-card-expense-account/account-select
/quickbooks-online/export/company-card-expense-account/default-vendor-select
/quickbooks-online/account-selector
/quickbooks-online/invoice-account-selector
/xero/export/bank-account-select
xero/advanced/bill-payment-account-selector
/xero/advanced/invoice-account-selector

CC: @Expensify/design @lakchote @hayata-suenaga

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c99a15ca9b588fc0
  • Upwork Job ID: 1793697280179924992
  • Last Price Increase: 2024-05-23
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. self-assigned this
    on May 23, 2024
  2. melvin-bot commented on May 23, 2024

    @melvin-bot

    Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  3. moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collecton May 23, 2024
  4. moved this from Release 1.5: XeroCon 2024 (June 12th) to Polish in [#whatsnext] #wave-collecton May 23, 2024
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 23, 2024
  6. changed the title [-][Xero] [QBO] Improve the empty state of pages when there are no imported accounts found [/-] [+][$250] [Xero] [QBO] Improve the empty state of pages when there are no imported accounts found [/+] on May 23, 2024
  7. melvin-bot commented on May 23, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 23, 2024
  9. melvin-bot commented on May 23, 2024

    @melvin-bot

    Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

  10. 24 remaining items

  11. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  12. s77rt commented on Jun 10, 2024

    @s77rt
    Member

    I don't think this requires a regression test

  13. trjExpensify commented on Jun 13, 2024

    @trjExpensify
    ContributorAuthor

    Agreed. Payment summary as follows:

    • $250 to @s77rt for the C+ review

    Offer sent!

  14. s77rt commented on Jun 13, 2024

    @s77rt
    Member

    @trjExpensify Accepted! Thanks! I believe @rushatgabhane is due payment for PR review

  15. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1793697280179924992/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. melvin-bot commented on Jun 18, 2024

    @melvin-bot

    @pecanoro, @trjExpensify, @s77rt Eep! 4 days overdue now. Issues have feelings too...

  17. trjExpensify commented on Jun 18, 2024

    @trjExpensify
    ContributorAuthor

    @trjExpensify Accepted! Thanks! I believe @rushatgabhane is due payment for PR review

    @rushatgabhane was paid already, settled up with you. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions