Repository navigation
Tax - Split scan - Selected tax rate is duplicated in Tax rate list #42642
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when validating #40240
Version Number: 1.4.76-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Precondition:
- Workspace is tax enabled.
- Workspace currency default and Foreign currency default have different tax rate in workspace tax settings.
- Go to staging.new.expensify.com
- Go to workspace chat.
- Create a split scan.
- When the receipt is scanning, click on the split preview.
- Click Amount.
- Change the currency to foreign currency.
- Enter amount and save it.
- Click Tax rate.
Expected Result:
The selected tax rate will not be duplicated.
Actual Result:
The selected tax rate is duplicated.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon May 27, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon May 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon May 27, 2024
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.m-natarajan commentedon May 27, 2024
@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon May 27, 2024
We think that this bug might be related to #vip-vsb
blimpich commentedon May 27, 2024
Looking into this
19 remaining items
cretadn22 commentedon May 29, 2024
@MonilBhavsar Thank you for your recognition of my efforts. After proposing solutions for 4 blockers, it appears they were implemented in the subsequent pull request. Could I suggest raising the bounty to $250 for the effort put into investigating and suggest solutions for those blockers? It seems more fitting than the current $125, which is only half the base price for an issue.
Christinadobrzyn commentedon Jun 5, 2024
checking with @MonilBhavsar on your request @cretadn22
MonilBhavsar commentedon Jun 6, 2024
I can't think of a reason why we should not. So I'm fine with paying it. Fine with what others has to say 👍
blimpich commentedon Jun 6, 2024
Sounds good to me 👍
@Christinadobrzyn can we pay out $250 to @cretadn22 and then close this issue?
Christinadobrzyn commentedon Jun 7, 2024
Yep! Payouts due:
Upwork job is here.
@cretadn22 can you accept? TY!
cretadn22 commentedon Jun 7, 2024
@Christinadobrzyn Done 🙏 Thanks so much
cretadn22 commentedon Jun 7, 2024
Awaiting payment from @Christinadobrzyn
Christinadobrzyn commentedon Jun 10, 2024
Thanks @cretadn22 - Paid out based on this payment summary - #42642 (comment)
Closing!