[$250] Tax - Split scan - Selected rate from confirmation page does not show up in split detail view

@DylanDylann

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40240

Action Performed:

Precondition:

Workspace is tax-enabled

Go to staging.new.expensify.com
Go to workspace chat
Go to + > Split expense > Scan
Upload a receipt
On confirmation page, click Tax rate
Select any rate
Click Split expense
Click on the split preview

Expected Result:

The selected tax rate will show up in Tax rate row in split details view

Actual Result:

The selected tax rate does not show up in Tax rate row in split details view. The row is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6493028_1716822433879.20240527_230419.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016b6987c10090fc2e
Upwork Job ID: 1795297947813523456
Last Price Increase: 2024-05-28

Issue Owner

Current Issue Owner: @DylanDylann

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kadiealexander

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-split

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split scan - Selected rate from confirmation page does not show up in split detail view

What is the root cause of that problem?

On a Workspace, when we split an expense, we go throw this function

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 344 to 355 in 9a87ce9

    
           IOU.startSplitBill({ 
        
               participants: selectedParticipants, 
        
               currentUserLogin: currentUserPersonalDetails.login, 
        
               currentUserAccountID: currentUserPersonalDetails.accountID, 
        
               comment: trimmedComment, 
        
               receipt: receiptFile, 
        
               existingSplitChatReportID: report?.reportID, 
        
               billable: transaction.billable, 
        
               category: transaction.category, 
        
               tag: transaction.tag, 
        
               currency: transaction.currency, 
        
           });

We are not passing the Tax detials like rate and amout to startSplitBill

What changes do you think we should make in order to solve the problem?

as we do for IOU.splitBill

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 380 to 381 in 9a87ce9

    
           taxCode: transactionTaxCode, 
        
           taxAmount: transactionTaxAmount,

We need to pass taxCode and taxAmount to IOU.startSplitBill

then use it inside the TransactionUtils.buildOptimisticTransaction

App/src/libs/actions/IOU.ts

Lines 4315 to 4332 in 9a87ce9

    
           const splitTransaction = TransactionUtils.buildOptimisticTransaction( 
        
               0, 
        
               currency, 
        
               CONST.REPORT.SPLIT_REPORTID, 
        
               comment, 
        
               '', 
        
               '', 
        
               '', 
        
               CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT, 
        
               receiptObject, 
        
               filename, 
        
               undefined, 
        
               category, 
        
               tag, 
        
               undefined, 
        
               undefined, 
        
               billable, 
        
           );

POC Video:

20240527_174248.mp4

What alternative solutions did you explore?

the revert #42670 has been deployed, please retest and confirm this is no longer reproducible.

Issue is not fixed.

42643.mp4

Job added to Upwork: https://www.upwork.com/jobs/~016b6987c10090fc2e

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split scan - Selected rate from confirmation page does not show up in split detail view

What is the root cause of that problem?

When we split expense by scanning we invoke startSplitBill function, but we don't pass taxRate and taxAmount to this function.

App/src/libs/actions/IOU.ts

Line 4559 in 9a87ce9

const parameters: StartSplitBillParams = {

One more thing, when adjusting the tax rate and amount, we invoke the completeSplitBill function, but we also don't pass taxRate and taxAmount

App/src/libs/actions/IOU.ts

Line 4800 in 95d328f

const parameters: CompleteSplitBillParams = {

What changes do you think we should make in order to solve the problem?

We need to update the optimisticData and params within the completeSplitBill and startSplitBill function to incorporate taxRate and taxAmount.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected tax rate does not show up in Tax rate row in split details view. The row is empty

What is the root cause of that problem?

We have two bug here

When we start split bill here, we don't accept taxCode and taxAmount param in this function to create optimistic transaction and pass it to param of StartSplitBill API

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 342 in 2514f29

IOU.startSplitBill({

When we edit tax rate and tax amount, we're calling UpdateMoneyRequestTaxRate API because we don't have the case for edit split bill here

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx

Line 76 in 2514f29

IOU.updateMoneyRequestTaxRate({

What changes do you think we should make in order to solve the problem?

Accept taxCode, taxAmount param in startSplitBill function and then use this to create optimistic transaction here.
Pas taxCode as transactionTaxCode and taxAmount as transactionTaxAmount into startSplitBill function here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 342 in 2514f29

IOU.startSplitBill({

Pass taxCode and taxAmount as param of StartSplitBill API here. We also need BE change to return taxCode and taxAmount of the transaction when we call StartSplitBill API

App/src/libs/actions/IOU.ts

Line 4540 in 2514f29

const parameters: StartSplitBillParams = {

When we edit split bill tax rate, we should call setDraftSplitTransaction as the revert PR here https://github.com/Expensify/App/pull/42670/files#diff-2d4b9c38f6fb668f527da301a60d3c9bb05c865f33aa475d29148bbda45e3cc0

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx

Line 76 in 2514f29

IOU.updateMoneyRequestTaxRate({

What alternative solutions did you explore? (Optional)

NA

@MonilBhavsar

This should be hold #39690

cc @MonilBhavsar

We can close this. This is new feature and not a bug

Navigation Menu

Repository navigation

[$250] Tax - Split scan - Selected rate from confirmation page does not show up in split detail view #42643

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	IOU.startSplitBill({
	participants: selectedParticipants,
	currentUserLogin: currentUserPersonalDetails.login,
	currentUserAccountID: currentUserPersonalDetails.accountID,
	comment: trimmedComment,
	receipt: receiptFile,
	existingSplitChatReportID: report?.reportID,
	billable: transaction.billable,
	category: transaction.category,
	tag: transaction.tag,
	currency: transaction.currency,
	});

	taxCode: transactionTaxCode,
	taxAmount: transactionTaxAmount,

	const splitTransaction = TransactionUtils.buildOptimisticTransaction(
	0,
	currency,
	CONST.REPORT.SPLIT_REPORTID,
	comment,
	'',
	'',
	'',
	CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT,
	receiptObject,
	filename,
	undefined,
	category,
	tag,
	undefined,
	undefined,
	billable,
	);

[$250] Tax - Split scan - Selected rate from confirmation page does not show up in split detail view #42643

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 27, 2024

lanitochka17 commented on May 27, 2024

lanitochka17 commented on May 27, 2024

dragnoir commented on May 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

bondydaa commented on May 27, 2024

kavimuru commented on May 28, 2024

melvin-bot commented on May 28, 2024

melvin-bot commented on May 28, 2024

cretadn22 commented on May 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented on May 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

DylanDylann commented on May 29, 2024

MonilBhavsar commented on May 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions