You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-28] [$250] mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview #42657
Version Number: 1.4.76.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4575560 Issue reported by: Applause - Internal Team
@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
What changes do you think we should make in order to solve the problem?
We can check if the attachment is a local file or not and only show AttachmentOfflineIndicator when the attachment is not a local file. We can also use isPreview prop of AttachmentOfflineIndicator.
changed the title [-]mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview[/-][+][$250] mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview[/+]on Jun 5, 2024
@dominictb Krishna posted a better proposal earlier than yours. Your proposal included a fix for another bug which I deemed not important. This is why I hired Krishna. Whether or not the bug you reported ends up getting fixed here or anywhere is not important. You do not "own" that bug and we never posted a job to fix it.
I'd appreciate it if you would let this go. The repeated back in forth in these comments is not really doing you any favors and this energy would be better spent on another proposal instead. Thank you 🙏
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon May 27, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.kbecciv commentedon May 27, 2024
We think that this bug might be related to #vip-vsb
kbecciv commentedon May 27, 2024
@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Krishna2323 commentedon May 27, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview
What is the root cause of that problem?
We use
AttachmentOfflineIndicatorcomponent for local files also andisLoadingis initially true.App/src/components/ImageView/index.tsx
Line 217 in fd322cc
App/src/components/ImageView/index.tsx
Line 251 in fd322cc
What changes do you think we should make in order to solve the problem?
We can check if the attachment is a local file or not and only show
AttachmentOfflineIndicatorwhen the attachment is not a local file. We can also useisPreviewprop ofAttachmentOfflineIndicator.We might also want to do the same in other components which uses
AttachmentOfflineIndicator.What alternative solutions did you explore? (Optional)
melvin-bot commentedon May 31, 2024
@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jun 3, 2024
@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
[-]mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview[/-][+][$250] mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview[/+]melvin-bot commentedon Jun 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~017a93bd4c637b4a77
34 remaining items
Krishna2323 commentedon Jun 28, 2024
@anmurali, bump for payments :)
dominictb commentedon Jun 29, 2024
@arosiclair What's your thought on this?
@mallenexpensify curious for your thought too on how you think we should handle this case.
Thanks
arosiclair commentedon Jul 1, 2024
@dominictb Krishna posted a better proposal earlier than yours. Your proposal included a fix for another bug which I deemed not important. This is why I hired Krishna. Whether or not the bug you reported ends up getting fixed here or anywhere is not important. You do not "own" that bug and we never posted a job to fix it.
I'd appreciate it if you would let this go. The repeated back in forth in these comments is not really doing you any favors and this energy would be better spent on another proposal instead. Thank you 🙏
melvin-bot commentedon Jul 1, 2024
@arosiclair, @anmurali, @Krishna2323, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jul 3, 2024
@arosiclair, @anmurali, @Krishna2323, @allgandalf Eep! 4 days overdue now. Issues have feelings too...
allgandalf commentedon Jul 4, 2024
Can you issue payments for this please @anmurali :)
melvin-bot commentedon Jul 5, 2024
@arosiclair, @anmurali, @Krishna2323, @allgandalf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
anmurali commentedon Jul 8, 2024
@Krishna2323 has been paid but @allgandalf still needs to complete the BZ checklist before payment is due.
allgandalf commentedon Jul 10, 2024
The PR that introduced the bug has been identified. Link to the PR: Fix - Attachment page keeps on loading infinitely. #39290
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/39290/files#r1672243491
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Verify offline message is not shown
Do we agree 👍 or 👎
anmurali commentedon Jul 10, 2024
@allgandalf - paid!