Skip to content

[HOLD for payment 2024-06-28] [$250] mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview #42657

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.76.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4575560
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Go offline

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a report
  3. Tap plus icon - upload an attachment image

Expected Result:

The image preview should be displayed even when uploading an attachment while offline.

Actual Result:

Uploading an image while offline briefly shows an offline message in the preview

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6493126_1716829499362.Screenrecorder-2024-05-27-21-18-51-168.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017a93bd4c637b4a77
  • Upwork Job ID: 1798155121003208704
  • Last Price Increase: 2024-06-05
  • Automatic offers:
    • allgandalf | Reviewer | 102625969
    • Krishna2323 | Contributor | 102625971
Issue OwnerCurrent Issue Owner: @anmurali

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2024
  2. melvin-bot commented on May 27, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. kbecciv commented on May 27, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb

  4. kbecciv commented on May 27, 2024

    @kbecciv
    Author

    @anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  5. Krishna2323 commented on May 27, 2024

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview

    What is the root cause of that problem?

    We use AttachmentOfflineIndicator component for local files also and isLoading is initially true.

    {isLoading && <AttachmentOfflineIndicator />}

    {isLoading && <AttachmentOfflineIndicator />}

    What changes do you think we should make in order to solve the problem?

    We can check if the attachment is a local file or not and only show AttachmentOfflineIndicator when the attachment is not a local file. We can also use isPreview prop of AttachmentOfflineIndicator.

    const isLocalFile = url.startsWith('blob:') || url.startsWith('file:');

    We might also want to do the same in other components which uses AttachmentOfflineIndicator.

    What alternative solutions did you explore? (Optional)

  6. melvin-bot commented on May 31, 2024

    @melvin-bot

    @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. melvin-bot commented on Jun 3, 2024

    @melvin-bot

    @anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 5, 2024
  9. changed the title [-]mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview[/-] [+][$250] mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview[/+] on Jun 5, 2024
  10. melvin-bot commented on Jun 5, 2024

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 5, 2024
  12. 34 remaining items

  13. Krishna2323 commented on Jun 28, 2024

    @Krishna2323
    Contributor

    @anmurali, bump for payments :)

  14. dominictb commented on Jun 29, 2024

    @dominictb
    Contributor

    @arosiclair What's your thought on this?

    @mallenexpensify curious for your thought too on how you think we should handle this case.

    Thanks

  15. arosiclair commented on Jul 1, 2024

    @arosiclair
    Contributor

    @dominictb Krishna posted a better proposal earlier than yours. Your proposal included a fix for another bug which I deemed not important. This is why I hired Krishna. Whether or not the bug you reported ends up getting fixed here or anywhere is not important. You do not "own" that bug and we never posted a job to fix it.

    I'd appreciate it if you would let this go. The repeated back in forth in these comments is not really doing you any favors and this energy would be better spent on another proposal instead. Thank you 🙏

  16. melvin-bot commented on Jul 1, 2024

    @melvin-bot

    @arosiclair, @anmurali, @Krishna2323, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    @arosiclair, @anmurali, @Krishna2323, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

  18. allgandalf commented on Jul 4, 2024

    @allgandalf
    Contributor

    Can you issue payments for this please @anmurali :)

  19. melvin-bot commented on Jul 5, 2024

    @melvin-bot

    @arosiclair, @anmurali, @Krishna2323, @allgandalf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  20. anmurali commented on Jul 8, 2024

    @anmurali

    @Krishna2323 has been paid but @allgandalf still needs to complete the BZ checklist before payment is due.

  21. allgandalf commented on Jul 10, 2024

    @allgandalf
    Contributor

    Regression Test Proposal

    1. Go offline
    2. Open a report
    3. Tap plus icon - upload an attachment image

    Verify offline message is not shown

    Do we agree 👍 or 👎

  22. anmurali commented on Jul 10, 2024

    @anmurali

    @allgandalf - paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions