Skip to content

[HOLD for payment 2024-06-13] User profile - App shows Hidden profile instead of not here page when profile link is invalid #42750

New issue
New issue
Closed
Closed
[HOLD for payment 2024-06-13] User profile - App shows Hidden profile instead of not here page when profile link is invalid#42750
Assignees
Kicus77rtmountinyjoekaufmanexpensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Description

@izarutskaya
izarutskaya
opened on May 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #42464
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Send a link of an invalid profile (https://staging.new.expensify.com/a/hellodsdsdsdsdsd
    ).
  4. Click on the link.

Expected Result:

App will show not here page.

Actual Result:

App shows profile of a Hidden user.
When clicking on Message Hidden, the report shows error.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6494994_1716979769510.invalid_user.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 29, 2024

  2. melvin-bot commented on May 29, 2024

    @melvin-bot
    melvin-botBot
    on May 29, 2024 – with Melvin Bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot
    assigned
    carlosmiceli
    and
    joekaufmanexpensify
    on May 29, 2024

  4. melvin-bot commented on May 29, 2024

    @melvin-bot
    melvin-botBot
    on May 29, 2024 – with Melvin Bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on May 29, 2024

  6. github-actions commented on May 29, 2024

    @github-actions
    github-actionsBot
    on May 29, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. izarutskaya commented on May 29, 2024

    @izarutskaya
    izarutskaya
    on May 29, 2024
    Author

    @joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  8. izarutskaya commented on May 29, 2024

    @izarutskaya
    izarutskaya
    on May 29, 2024
    Author

    We think this issue might be related to the #vip-vsb.

  9. izarutskaya commented on May 29, 2024

    @izarutskaya
    izarutskaya
    on May 29, 2024
    Author

    Production

    bandicam.2024-05-29.14-29-34-189.mp4

  10. 22 remaining items

  11. melvin-bot
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on May 29, 2024

  12. Kicu commented on May 29, 2024

    @Kicu
    Kicu
    on May 29, 2024
    Contributor

    PR with fix is here: #42769

    I hope there is no more edge cases for this view that I missed, but what I did should be equivalent to the code that was handling this previously

  13. joekaufmanexpensify commented on Jun 3, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Jun 3, 2024
    Contributor

    PR awaiting deploy

  14. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Jun 6, 2024
  15. melvin-bot
    changed the title [-]User profile - App shows Hidden profile instead of not here page when profile link is invalid[/-] [+][HOLD for payment 2024-06-13] User profile - App shows Hidden profile instead of not here page when profile link is invalid[/+] on Jun 6, 2024
  16. melvin-bot
    removed
    ReviewingHas a PR in review
    on Jun 6, 2024

  17. melvin-bot commented on Jun 6, 2024

    @melvin-bot
    melvin-botBot
    on Jun 6, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Jun 6, 2024

    @melvin-bot
    melvin-botBot
    on Jun 6, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Kicu does not require payment (Contractor)
    • @s77rt requires payment (Needs manual offer from BZ)

  19. melvin-bot commented on Jun 6, 2024

    @melvin-bot
    melvin-botBot
    on Jun 6, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  20. joekaufmanexpensify commented on Jun 10, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Jun 10, 2024
    Contributor

    This was fixing a deploy blocker introduced from another PR that @Kicu and @s77rt worked on, so no payment is due here.

  21. joekaufmanexpensify commented on Jun 10, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Jun 10, 2024
    Contributor

    Closing as this is on production, thanks everyone!

  22. joekaufmanexpensify
    closed this as completedon Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions