[Awaiting Payment 22nd June] [$250] [Pending/Scanning] Card transactions show Cash in the expense preview instead of Card

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.77-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717026809436129

Action Performed:

Incur a card transaction on an expensify card
Add a manual request to that same report

Expected Result:

The expense preview should say Card for card transactions.

Actual Result:

The card transactions show as Cash

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fc32ffbea0b1bdc5
Upwork Job ID: 1796170573012758528
Last Price Increase: 2024-05-30
Automatic offers:

Nodebrute | Contributor | 102573646

Issue Owner

Current Issue Owner: @parasharrajat

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Propsal

Please re-state the problem that we are trying to solve in this issue

card transactions show Cash in the expense preview

What is the root cause of that problem?

This is a feature request. We don't have any logic to show Card instead of cash

What changes do you thing we should make in order to solve the problem?

We should add another check in getPreviewHeaderText in MoneyRequestPreviewContent.tsx

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 139 to 143 in f26c9f5

    
           const getPreviewHeaderText = (): string => { 
        
               let message = translate('iou.cash'); 
        
               if (isDistanceRequest) { 
        
                   message = translate('common.distance');

We can do something like this

if(isCardTransaction){
message = translate('iou.card')
}

We should also check for other places where we want to show card instead of cash

If we only want to use Card for expensify card transactions then we can use check isExpensifyCardTransaction

What alternative solutions did you explore?

We can also do it like this here

let message = isCardTransaction ? translate('iou.card') : translate('iou.cash')

Job added to Upwork: https://www.upwork.com/jobs/~01fc32ffbea0b1bdc5

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@Nodebrute

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

PR was deployed 5 days back on PROD. Not sure why the status was not updated here.

@grgia

@grgia The PR went into production on June 15th. The payment was due on June 22nd. Unfortunately, this issue missed the automatic payment date. Kindly issue the payment.

@parasharrajat

Payment summary as follows:

@parasharrajat $250 for the C+ review (feel free to request!)
@Nodebrute $250 for the fix (paid!)

Regression tests for the project will be added centrally. Closing!

Payment requested as per #42832 (comment)

@parasharrajat

$250 approved for @parasharrajat

Navigation Menu

Repository navigation

[Awaiting Payment 22nd June] [$250] [Pending/Scanning] Card transactions show `Cash` in the expense preview instead of `Card` #42832

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Propsal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you thing we should make in order to solve the problem?

What alternative solutions did you explore?

8 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const getPreviewHeaderText = (): string => {
	let message = translate('iou.cash');

	if (isDistanceRequest) {
	message = translate('common.distance');

[Awaiting Payment 22nd June] [$250] [Pending/Scanning] Card transactions show Cash in the expense preview instead of Card #42832

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 30, 2024

Nodebrute commented on May 30, 2024

Propsal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you thing we should make in order to solve the problem?

What alternative solutions did you explore?

melvin-bot commented on May 30, 2024

melvin-bot commented on May 30, 2024

8 remaining items

melvin-bot commented on Jun 3, 2024

parasharrajat commented on Jun 20, 2024

Nodebrute commented on Jun 23, 2024

trjExpensify commented on Jun 24, 2024

parasharrajat commented on Jun 29, 2024

JmillsExpensify commented on Jul 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[Awaiting Payment 22nd June] [$250] [Pending/Scanning] Card transactions show `Cash` in the expense preview instead of `Card` #42832