Repository navigation
[HOLD for payment 2024-08-07] [QBO Export] Implement offline pattern B for manual report exports #43040
Description
Part of QBO Export and Error Handling in NewDot
Doc section: https://docs.google.com/document/d/1aQl-AK_F6IqszWYG2aEllTsD5x3h4b8Zu0XEG0LuQ08/edit#heading=h.xw0s9oqvo44s
Project: [#whatsnext] #wave-collect
Feature Description
During review for the detailed design, we decided we should support offline pattern B when manually exporting reports here. To implement that we need to
- Create an optimistic
EXPORTINTEGRATIONaction in ourReport.exportToIntegrationandReport.markAsManuallyExportedactions- The text should say
started exporting this report to {integration}...
- The text should say
- Pass the
optimisticReportActionIDto bothReport_ExportandMarkAsExportedAPIs - Use the ID to create the action in Auth
- Auth will queue updates for the report action with the final text:
exported this report to {integration}. [View out-of-pocket expenses].
- Auth will queue updates for the report action with the final text:
- On failure
- create the
INTEGRATIONSMESSAGEaction with the error message like normal (using a different ID) - delete the optimistic action on the frontend using
failureData
- create the
Manual Test Steps
Sucessful offline export
- Submit an expense report
- Log in as the workspace admin
- Approve the report
- Go offline
- 3-dot menu > Export > Quickbooks Online
- Verify a semi-transparent
started exporting this report to QuickBooks Online...message shows - Go online
- Verify the action becomes fully opaque
- Wait a few seconds
- Verify the action updates to
exported this report to QuickBooks Online. [View out-of-pocket expenses].
Failed offline export
Prerequisites
- Add a chart of account (category) to QBO that you can delete later
Steps
- Create a report with an expense
- Categorize the expense using the new QBO category
- Submit it
- Log in as the workspace admin and approve the report
- Log into QBO and deactivate the chart of account for the category (Menu > Transactions > Chart of accounts > {account} menu > Make inactive)
- Go offline in NewDot
- Export the report to QBO (3-dot menu > Export > Quickbooks Online)
- Verify a semi-transparent
started exporting this report to QuickBooks Online...message shows - Go online
- Verify the action becomes fully opaque
- Wait a few seconds
- Verify a report export error message is added the report
Automated Tests
- Verify optimisticData for the
INTEGRATIONSMESSAGEis merged for bothReport.exportToIntegrationandReport.markAsManuallyExportedactions - Verify failureData removes the action
Activity
melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @dylanexpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.[-]Implement offline pattern B for manual report exports[/-][+][HOLD] Implement offline pattern B for manual report exports[/+]arosiclair commentedon Jun 4, 2024
cc @trjExpensify @lakchote @sakluger
[-][HOLD] Implement offline pattern B for manual report exports[/-][+][HOLD] [QBO Export] Implement offline pattern B for manual report exports[/+]trjExpensify commentedon Jun 6, 2024
Sounds good, moved it into the release. 👍
dylanexpensify commentedon Jun 17, 2024
Held!
arosiclair commentedon Jun 19, 2024
Pointed the hold to #44022
[-][HOLD] [QBO Export] Implement offline pattern B for manual report exports[/-][+][HOLD #44022] [QBO Export] Implement offline pattern B for manual report exports[/+]38 remaining items
[-][QBO Export] Implement offline pattern B for manual report exports[/-][+][HOLD for payment 2024-08-07] [QBO Export] Implement offline pattern B for manual report exports[/+]melvin-bot commentedon Jul 31, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 31, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 31, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dylanexpensify commentedon Aug 5, 2024
Payment coming up!
melvin-bot commentedon Aug 7, 2024
Payment Summary
Upwork Job
BugZero Checklist (@dylanexpensify)
dylanexpensify commentedon Aug 8, 2024
Payment summary:
Please apply/request!
JmillsExpensify commentedon Aug 14, 2024
$250 approved for @hungvu193