Skip to content

Android & iOS - Profile - Default avatar is small when viewed in full screen #43050

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to any chat.
  3. Tap on the chat header.
  4. Tap on the user avatar.

Expected Result:

User avatar will not appear small when viewed in full screen.

Actual Result:

User avatar is small when viewed in full screen.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6501800_1717519658236.Screen_Recording_20240605_004544_New_Expensify.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 4, 2024
  2. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jun 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 4, 2024

    @m-natarajan
    Author

    @bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jun 4, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-vsb

  7. neil-marcellini commented on Jun 4, 2024

    @neil-marcellini
    Contributor

    I'm 90% sure this is not a backend deploy blocker

  8. bernhardoj commented on Jun 5, 2024

    @bernhardoj
    Contributor

    It's from #42174 where we don't scale the image to fit the screen anymore (except bigger image than the screen).

  9. bondydaa commented on Jun 5, 2024

    @bondydaa
    Contributor

    cc @samilabud @arosiclair @eVoloshchak can you take a look and confirm if this was from your PR?

  10. samilabud commented on Jun 5, 2024

    @samilabud
    Contributor

    cc @samilabud @arosiclair @eVoloshchak can you take a look and confirm if this was from your PR?

    Confirmed!

    what should the expected behavior? most of the time images that are smaller than the container are pixelated, hence the origin of the change.

  11. arosiclair commented on Jun 5, 2024

    @arosiclair
    Contributor

    This should be expected behavior now. We're no longer scaling up small images automatically (you can still pinch to zoom though).

  12. bondydaa commented on Jun 5, 2024

    @bondydaa
    Contributor

    ah coolio @m-natarajan please make a note this is now expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions