Skip to content

[HOLD for payment 2024-06-28] [$250] Distance - "Center" button has no hover and press effect #43058

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4-79-3
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #40759

Action Performed:

Precondition:

  • App location permission is allowed
  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense > Distance
  3. Hover over "Center" button
  4. Click on the "Center" button

Expected Result:

There should be hover and press effect on the button when hovering over and pressing on the button

Actual Result:

"Center" button has no hover and press effect

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6501921_1717526328081.bandicam_2024-06-05_02-12-52-626.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ba9155072ebd3afb
  • Upwork Job ID: 1798088916367302656
  • Last Price Increase: 2024-06-04
  • Automatic offers:
    • jjcoffee | Reviewer | 102678374
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 4, 2024
  2. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 4, 2024

    @lanitochka17
    Author

    @marcochavezf FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. marcochavezf commented on Jun 4, 2024

    @marcochavezf
    Contributor

    There's no center button in production:

    Screenshot 2024-06-04 at 2 20 12 p m

    I don't think this is a deploy blocker, but I will make it external

  6. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 4, 2024
  7. 52 remaining items

  8. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
    • [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jjcoffee] Determine if we should create a regression test for this bug.
    • [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. jjcoffee commented on Jun 26, 2024

    @jjcoffee
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: fix add center button and blue dot #40759
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40759/files#r1654477558
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Go to FAB > Submit expense > Distance
    2. Hover over "Center" button and verify that the button style changes
    3. Tap and hold on the "Center" button and verify that the button style changes

    Do we agree 👍 or 👎

  12. adelekennedy commented on Jul 1, 2024

    @adelekennedy
    Contributor

    @marcochavezf to review the regression test proposal above, also changing the total price to $125 for the regression

  13. adelekennedy commented on Jul 1, 2024

    @adelekennedy
    Contributor

    Payouts due:

    @truph01 will you share your upwork profile with em so I can extend a manual offer?

  14. truph01 commented on Jul 1, 2024

    @truph01
    Contributor
  15. adelekennedy commented on Jul 1, 2024

    @adelekennedy
    Contributor

    offer sent @truph01

  16. truph01 commented on Jul 2, 2024

    @truph01
    Contributor

    @adelekennedy Accepted thanks!

  17. adelekennedy commented on Jul 2, 2024

    @adelekennedy
    Contributor

    Payments made! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions