Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Subscription size value not trim able to add spaces before the value #43069
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when validating the PR #42683
Version Number: 1.4.79-2
Reproducible in staging?: y
Reproducible in production?: New feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Go to /settings/subscription/subscription-size
- Enter spaces and then a values click next
- Notice spaces showing on next page
Expected Result:
Spaces should not displayed with value
Actual Result:
Subscription size value not trim able to add spaces before the value
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6501964_1717527964130.2024-06-04_23-59-06.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0110dce96b3114bcdc
- Upwork Job ID: 1798096545497235456
- Last Price Increase: 2024-06-04
- Automatic offers:
- bernhardoj | Contributor | 102646806
Activity
melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 4, 2024
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @tylerkaraszewski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 4, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0110dce96b3114bcdc
52 remaining items
[-][HOLD for payment 2024-06-24] [$250] Subscription size value not trim able to add spaces before the value[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Subscription size value not trim able to add spaces before the value[/+]melvin-bot commentedon Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Jun 25, 2024
Payouts due:
Upwork job is here.
@thesahindia let us know about a regression test!
Christinadobrzyn commentedon Jun 26, 2024
still have a few days till payment!
thesahindia commentedon Jun 27, 2024
This bug was present since the implementation of this page. It was a minor issue that got missed in #42683. I don't think we need a test case for this.
Christinadobrzyn commentedon Jun 27, 2024
Sounds good - no regression test for this. Thanks @thesahindia!
Christinadobrzyn commentedon Jun 28, 2024
Awesome! Payment summary is here - #43069 (comment)
This is good to close. Feel free to reach out if I missed anything.
JmillsExpensify commentedon Jul 19, 2024
$250 approved for @thesahindia