You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Expense - "Receipt" label does not appear above receipt placeholder for p2p expense #43076
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: #41635
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #41635 (comment)
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. No, this bug isn't impactful enough to create a regression test
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a
@getusha looks like we're still waiting for you to accept the payment in Upwork. Please let me know once you accept and I can get that paid ASAP. Thank you!
changed the title [-][HOLD for payment 2024-07-02] [$125] Expense - "Receipt" label does not appear above receipt placeholder for p2p expense[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Expense - "Receipt" label does not appear above receipt placeholder for p2p expense[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR:
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug.
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @luacmartins (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 4, 2024
@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon Jun 4, 2024
We think that this bug might be related to #wave-collect - Release 1
neonbhai commentedon Jun 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Receipt" label does not appear above receipt placeholder for p2p expense
What is the root cause of that problem?
We check for a paid group policy when showing receipt header
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 333 in 594ae48
What changes do you think we should make in order to solve the problem?
We should remove the paid group policy check here
48 remaining items
CortneyOfstad commentedon Jun 28, 2024
@getusha can you please complete the checklist above before beginning of next week, so there is no delay in payment? Thanks!
getusha commentedon Jun 28, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: #41635
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #41635 (comment)
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. No, this bug isn't impactful enough to create a regression test
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a
CortneyOfstad commentedon Jul 2, 2024
@getusha looks like we're still waiting for you to accept the payment in Upwork. Please let me know once you accept and I can get that paid ASAP. Thank you!
CortneyOfstad commentedon Jul 3, 2024
Bump @getusha ^^^
I am heading OoO until Tuesday (July 9th) so I would like to get this paid as soon as possible without any further delay. Thanks!
getusha commentedon Jul 3, 2024
Accepted, thanks @CortneyOfstad
luacmartins commentedon Jul 3, 2024
@CortneyOfstad seems like the offer was accepted, can we close this issue now?
[-][HOLD for payment 2024-07-02] [$125] Expense - "Receipt" label does not appear above receipt placeholder for p2p expense[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Expense - "Receipt" label does not appear above receipt placeholder for p2p expense[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
CortneyOfstad commentedon Jul 9, 2024
Payment Summary
@getusha — paid $125 via Upwork
@neonbhai — paid $125 via Upwork