Skip to content

Distance tax - Tax amount is zero when selecting a distance rate on confirmation page #43111

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #42909
Version Number: 1.4.79-6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

  • Track Tax distance is enabled on Old Dot.
  • Workspace has a few distance rates and the distance rates are associated with tax rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Go to + > Submit expense > Distance.
  4. Enter waypoints > Next.
  5. Click Rate.
  6. Select a distance that has non-zero tax rate.

Expected Result:

The tax amount will update accordingly.

Actual Result:

The tax amount is zero on confirmation page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6502302_1717562207284.bandicam_2024-06-05_12-30-33-805.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 5, 2024
  2. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 5, 2024

    @m-natarajan
    Author

    @mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jun 5, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-collect - Release 1

  7. MonilBhavsar commented on Jun 5, 2024

    @MonilBhavsar
    Contributor

    Will look as it is coming from my PR

  8. self-assigned this
    on Jun 5, 2024
  9. MonilBhavsar commented on Jun 5, 2024

    @MonilBhavsar
    Contributor

    Not a Web-E blocker

  10. trjExpensify commented on Jun 5, 2024

    @trjExpensify
    Contributor

    @MonilBhavsar Tax reclaimable portion in the tester's video is $0.00 for all rates:

    image

    ... so it doesn't matter whatever rate they select. The amount of tax reclaimable on it is $0.00, so therefore the Tax amount is $0.00 on the expense:

    image
  11. MonilBhavsar commented on Jun 5, 2024

    @MonilBhavsar
    Contributor

    @m-natarajan this is not a bug and feature -

    Here -

    Screenshot 2024-06-05 at 7 40 32 PM

    The field Tax reclaimable on should not be 0.00. If you update it to non zero, you should be able to see non zero tax amount. Could you please help to recheck. Thanks!

  12. MonilBhavsar commented on Jun 5, 2024

    @MonilBhavsar
    Contributor

    Lol 😄

  13. trjExpensify commented on Jun 5, 2024

    @trjExpensify
    Contributor

    Hahahahah

  14. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 5, 2024
  15. carlosmiceli commented on Jun 5, 2024

    @carlosmiceli
    Contributor

    Just getting here, not sure I understood if this is a bug or not 😅

  16. trjExpensify commented on Jun 5, 2024

    @trjExpensify
    Contributor

    Not a bug.

  17. carlosmiceli commented on Jun 5, 2024

    @carlosmiceli
    Contributor

    Should be closed then, right?

  18. trjExpensify commented on Jun 5, 2024

    @trjExpensify
    Contributor

    Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions