Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] [$250] Distance - Unable to remove stop from the route #43112

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4596214
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Create a distance request with 3 waypoints
  2. Navigate to the distance expense details conversation
  3. Tap on three dots and select "delete waypoint
  4. Tap on Delete/Cancel button

Expected Result:

Able to remove stop from the route.

Actual Result:

Unable to remove stop from the route, keyboard opens and covering button Delete/Cancel

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6502121_1717537437193.RPReplay_Final1717537368.mp4

Bug6502121_1717537437192!IMG_5764

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d0550e482bb178b0
  • Upwork Job ID: 1798405478156472047
  • Last Price Increase: 2024-06-05
  • Automatic offers:
    • ishpaul777 | Contributor | 102614122
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 5, 2024
  2. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 5, 2024

    @m-natarajan
    Author

    @trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jun 5, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-vsb

  7. 31 remaining items

  8. changed the title [-][HOLD for payment 2024-06-13] [$250] Distance - Unable to remove stop from the route[/-] [+][HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] [$250] Distance - Unable to remove stop from the route[/+] on Jun 11, 2024
  9. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-18. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. ishpaul777 commented on Jun 12, 2024

    @ishpaul777
    Contributor

    [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: #42423
    [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #42423
    [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    [@ishpaul777] Determine if we should create a regression test for this bug. - NO
    [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. -N/A

  12. ishpaul777 commented on Jun 12, 2024

    @ishpaul777
    Contributor

    No regression test required since this is caught during a QA there must be associated test related to this flow already

  13. changed the title [-][HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] [$250] Distance - Unable to remove stop from the route[/-] [+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] [$250] Distance - Unable to remove stop from the route[/+] on Jun 13, 2024
  14. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. trjExpensify commented on Jun 20, 2024

    @trjExpensify
    Contributor

    Payment summary as follows:

    Paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions