You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access #43113
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Yep, this seems like it should be external! I'll try to look into it to but open to proposals. I didn't see an obvious PR that would have caused it but will investigate.
@m-natarajan this doesn't happen on production, correct?
changed the title [-][$250] Distance - Blue dot does not set to current location after enabling location access[/-][+][HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
[@fedirjh / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
Unfortunately, I didn’t find the PR that introduced the bug
But on the other side, all the changes in this PR are more related to code refactoring
[@fedirjh / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
NA
[@fedirjh / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
NA
[@fedirjh / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
[@fedirjh / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Open the app and log in
Tap the FAB -> Submit expense -> Distance
Select do not allow on the pop-up and wait for the map to load
Tap the start point and select Use current location
Allow location access
Verify blue dot is displayed as the user's current location
Activity
melvin-bot commentedon Jun 5, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 5, 2024
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 5, 2024
@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon Jun 5, 2024
We think that this bug might be related to #wave-collect - Release 1
dangrous commentedon Jun 5, 2024
Yep, this seems like it should be external! I'll try to look into it to but open to proposals. I didn't see an obvious PR that would have caused it but will investigate.
@m-natarajan this doesn't happen on production, correct?
58 remaining items
[-][$250] Distance - Blue dot does not set to current location after enabling location access[/-][+][HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access[/+]melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ZhenjaHorbach commentedon Jul 10, 2024
Unfortunately, I didn’t find the PR that introduced the bug
But on the other side, all the changes in this PR are more related to code refactoring
NA
NA
Regression Test Proposal
Do we agree 👍 or 👎
sakluger commentedon Jul 10, 2024
@fedirjh I withdrew the Upwork offer since you can now request payment via NewDot. I'll post the payment summary below.
sakluger commentedon Jul 10, 2024
Summarizing payment on this issue:
Contributor: @fedirjh $250, please request on Newdot
Contributor+: @ZhenjaHorbach $250, paid via Upwork
JmillsExpensify commentedon Jul 11, 2024
$250 approved for @fedirjh