Skip to content

[HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access #43113

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79-6
Reproducible in staging?: y
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4597262
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

precondition: location access is disabled

  1. Open the app and log in
  2. Tap the FAB > Submit expense >Distance
  3. Select do not allow on the pop-up and wait for the map to load
  4. Tap the start point and select Use current location
  5. Allow location access

Expected Result:

The blue dot is displayed as user's current location and replaces the start point on the map

Actual Result:

The blue dot is still displayed over San Francisco while the start point is set to the current location

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6502239_1717554700706.video_2024-06-04_22-29-07.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0194e3d6c394ce03d6
  • Upwork Job ID: 1798364343763573802
  • Last Price Increase: 2024-06-12
  • Automatic offers:
    • fedirjh | Reviewer | 102783101
    • ZhenjaHorbach | Contributor | 102783102
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 5, 2024
  2. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jun 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 5, 2024

    @m-natarajan
    Author

    @dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jun 5, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-collect - Release 1

  7. dangrous commented on Jun 5, 2024

    @dangrous
    Contributor

    Yep, this seems like it should be external! I'll try to look into it to but open to proposals. I didn't see an obvious PR that would have caused it but will investigate.

    @m-natarajan this doesn't happen on production, correct?

  8. 58 remaining items

  9. changed the title [-][$250] Distance - Blue dot does not set to current location after enabling location access[/-] [+][HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access[/+] on Jul 3, 2024
  10. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
    • [@fedirjh / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. ZhenjaHorbach commented on Jul 10, 2024

    @ZhenjaHorbach
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Unfortunately, I didn’t find the PR that introduced the bug
    But on the other side, all the changes in this PR are more related to code refactoring

    • [@fedirjh / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    NA

    • [@fedirjh / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    NA

    Regression Test Proposal

    1. Open the app and log in
    2. Tap the FAB -> Submit expense -> Distance
    3. Select do not allow on the pop-up and wait for the map to load
    4. Tap the start point and select Use current location
    5. Allow location access
    6. Verify blue dot is displayed as the user's current location

    Do we agree 👍 or 👎

  14. sakluger commented on Jul 10, 2024

    @sakluger
    Contributor

    @fedirjh I withdrew the Upwork offer since you can now request payment via NewDot. I'll post the payment summary below.

  15. sakluger commented on Jul 10, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @fedirjh $250, please request on Newdot
    Contributor+: @ZhenjaHorbach $250, paid via Upwork

  16. JmillsExpensify commented on Jul 11, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions