You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] Troubleshoot - App is stuck offline after "Force offline" toggled on and off #43116
Version Number: 1.4.79-3 Reproducible in staging?: Y Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Log in to New Expensify
Navigate to Account settings > Troubleshoot
Toggle on and off the "Force offline" toggle
Expected Result:
The App should go online after switching off the "Force offline" toggle
Actual Result:
The App is stuck in the offline state. The offline indicator remains.
User is forced to either refresh the page or force-kill the app in order to return online
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
`[NetworkStatus] The force-offline mode was turned off. Getting the device network status from NetInfo. Network state: ${JSON.stringify(
state,
)}. Setting the offline status to: ${isInternetReachable}.`,
);
What changes do you think we should make in order to solve the problem?
Change it to this:
NetInfo.fetch().then((state) => {
const isOffline = !(state.isInternetReachable ?? false);
setOfflineStatus(isOffline);
Log.info(
`[NetworkStatus] The force-offline mode was turned off. Getting the device network status from NetInfo. Network state: ${JSON.stringify(
state,
)}. Setting the offline status to: ${isOffline}.`,
);
});
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
[@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Santhosh-Sellavel / @nkdengineer] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Issue is ready for payment but no BZ is assigned. @strepanier03 you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
melvin-bot commentedon Jun 5, 2024
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 5, 2024
@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
ShridharGoel commentedon Jun 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Troubleshoot - App is stuck offline after "Force offline" toggled on and off.
What is the root cause of that problem?
The below logic is wrong,
setOfflineStatusexpects isOffline kind of value but actually the opposite is being passed.App/src/libs/NetworkConnection.ts
Lines 82 to 88 in 8dbec8d
What changes do you think we should make in order to solve the problem?
Change it to this:
ShridharGoel commentedon Jun 5, 2024
@pecanoro I can quickly open a PR if this is a blocker.
neil-marcellini commentedon Jun 5, 2024
Frontend only bug. In fact, since this is a test tool only it shouldn't be a blocker at all
21 remaining items
melvin-bot commentedon Jun 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jun 20, 2024
Issue is ready for payment but no BZ is assigned. @strepanier03 you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Jun 20, 2024
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
strepanier03 commentedon Jun 20, 2024
Aaaah, I made the job before I reviewed above and it looks like this might be a fix for a bug stemming from #41719.
Seeing as this is a fix for a regression caused, I don't believe there is any payment due here.
strepanier03 commentedon Jun 20, 2024
I'll circle back to this tomorrow in case there's any pushback. If not I'll cancel the job I make in Upwork and close this out.
melvin-bot commentedon Jun 24, 2024
@pecanoro, @strepanier03, @Santhosh-Sellavel, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
strepanier03 commentedon Jun 24, 2024
Closing out, thanks everyone!