Skip to content

QBO - Location switch button hint text is not as expected #43119

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when verifying #41638
Version Number: 1.4.79-6
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Create a new workspace
  2. Go to the More Feature page and enable the accounting feature
  3. Connect to QBO
  4. Go to the Export page. Check that Vendor Bill is selected for Export out-of-pocket expenses as by default
  5. Go to the Import page. Check the Location configuration. Check that the Switch is toggled off and locked.

Expected Result:

There should be a hint text under the Switch button. Use the screenshot attached as a reference.

Actual Result:

A hint text under the Switch button is different (screenshot attached)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Expected text hint

Bug6502548_1717580957810!expected

Actual text hint
Bug6502548_1717580957811!actual

Bug6502548_1717580957798.hint_for_accounting.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @hayata-suenaga

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 5, 2024
  2. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 5, 2024

    @m-natarajan
    Author

    @kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. dragnoir commented on Jun 5, 2024

    @dragnoir
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    QBO wrong description

    What is the root cause of that problem?

    Wrong text for the description used on QBO Locations page

    locationsAdditionalDescription: `QuickBooks Online does not support adding a location to vendor bills or checks. Update your export preference to journal entry if you'd like to import locations as tags.`,

    What changes do you think we should make in order to solve the problem?

    Set the new text here

    locationsAdditionalDescription: `QuickBooks Online does not support adding a location to vendor bills or checks. Update your export preference to journal entry if you'd like to import locations as tags.`,

    and update the spanish language

    What alternative solutions did you explore?

  7. bondydaa commented on Jun 5, 2024

    @bondydaa
    Contributor

    I don't think this is a blocker, the copy was changed here bcecada

    cc @hayata-suenaga can you confirm. We probably just need to update the QA test steps with the latest copy.

  8. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 5, 2024
  9. trjExpensify commented on Jun 5, 2024

    @trjExpensify
    Contributor

    Yep, this was an intentional change. I'd close this issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions