You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Categories - All categories disappear instead of crossed out when deleted offline #43127
Version Number: 1.4-79-7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Workspace has categories and tags
Go to staging.new.expensify.com
Go to workspace settings > Tags
Go offline
Delete all tags
Note that all tags are crossed out
Go to Categories
Delete all categories
Note that it shows empty state instead of all categories being crossed out
Expected Result:
All the categories will be crossed out when deleted offline
Actual Result:
Categories page shows empty state instead of showing all deleted categories being crossed out
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
Categories - All categories disappear instead of crossed out when deleted offline
What is the root cause of that problem?
The root cause of the problem is that the WorkspaceTagsPage has a condition for shouldShowEmptyState which only true by checking the if some the categories have pendingAction of DELETE in the categoryList instead of all.
It would be easier for us to read the condition above (because it's not a negated variable), so I suggest to follow the same pattern in tags page and apply it to the categories page.
changed the title [-]Categories - All categories disappear instead of crossed out when deleted offline [/-][+][$250] Categories - All categories disappear instead of crossed out when deleted offline [/+]on Jun 6, 2024
changed the title [-][$250] Categories - All categories disappear instead of crossed out when deleted offline [/-][+][HOLD for payment 2024-07-17] [$250] Categories - All categories disappear instead of crossed out when deleted offline [/+]on Jul 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rayane-djouah / @situchan] The PR that introduced the bug has been identified. Link to the PR:
[@rayane-djouah / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rayane-djouah / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rayane-djouah / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-07-17] [$250] Categories - All categories disappear instead of crossed out when deleted offline [/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Categories - All categories disappear instead of crossed out when deleted offline [/+]on Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rayane-djouah / @situchan] The PR that introduced the bug has been identified. Link to the PR:
[@rayane-djouah / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rayane-djouah / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rayane-djouah / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Regression Test
Precondition: Workspace has categories
Go offline
Go to workspace settings > Categories
Delete all categories
Verify that all the categories are crossed out when deleted offline
Activity
melvin-bot commentedon Jun 5, 2024
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 5, 2024
@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 5, 2024
We think that this bug might be related to #wave-collect - Release 1
dragnoir commentedon Jun 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Removed categories hidden when offline
What is the root cause of that problem?
On
WorkspaceTagsPagewe check the display of the SelectionList withhasVisibleTaghttps://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/pages/workspace/tags/WorkspaceTagsPage.tsx#L341C18-L341C32
but on
WorkspaceCategoriesPagewe do the same display check with!shouldShowEmptyStateApp/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Line 327 in 66b4072
What changes do you think we should make in order to solve the problem?
on
WorkspaceCategoriesPagewe need to fixshouldShowEmptyStateto be the same as we use onWorkspaceTagsPageApp/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Line 259 in 66b4072
What alternative solutions did you explore?
Tony-MK commentedon Jun 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Categories - All categories disappear instead of crossed out when deleted offline
What is the root cause of that problem?
The root cause of the problem is that the
WorkspaceTagsPagehas a condition forshouldShowEmptyStatewhich onlytrueby checking the if some the categories havependingActionofDELETEin thecategoryListinstead of all.App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Lines 320 to 326 in 66b4072
App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Line 259 in 66b4072
What changes do you think we should make in order to solve the problem?
On the
WorkspaceTagsPage, the condition ofshouldShowEmptyStateshould be like the one below.bernhardoj commentedon Jun 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Category shows empty view state instead of crossed out categories list while offline.
What is the root cause of that problem?
The empty view state will be shown if every item is PENDING_DELETE even if it's offline.
App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Line 259 in 8dbec8d
What changes do you think we should make in order to solve the problem?
We should do the same with tags page where it consider the offline status.
App/src/pages/workspace/tags/WorkspaceTagsPage.tsx
Line 293 in 8dbec8d
It would be easier for us to read the condition above (because it's not a negated variable), so I suggest to follow the same pattern in tags page and apply it to the categories page.
and adjust the other code usages.
melvin-bot commentedon Jun 6, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01175e1115f886adb6
[-]Categories - All categories disappear instead of crossed out when deleted offline [/-][+][$250] Categories - All categories disappear instead of crossed out when deleted offline [/+]melvin-bot commentedon Jun 6, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)35 remaining items
[-][$250] Categories - All categories disappear instead of crossed out when deleted offline [/-][+][HOLD for payment 2024-07-17] [$250] Categories - All categories disappear instead of crossed out when deleted offline [/+]melvin-bot commentedon Jul 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-07-17] [$250] Categories - All categories disappear instead of crossed out when deleted offline [/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Categories - All categories disappear instead of crossed out when deleted offline [/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mallenexpensify commentedon Jul 18, 2024
Contributor: @rayane-djouah paid $250 via Upwork
Contributor+: @situchan paid $250 via Upwork
@situchan can you please complete the BZ checklist above? Thx
situchan commentedon Jul 18, 2024
Regression Test
Precondition: Workspace has categories
mallenexpensify commentedon Jul 19, 2024
Thanks @situchan
TestRail GH