You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-21] [$250] mWeb - Chat - Quote markdown is not applied #43180
Version Number: 1.4.82-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
This PR changes quote regex to enforce following space after >.
not followed by space won't be parsed as quote. In the multiple level quote context spaces between > signs are irrelevent
If this is indeed the new expected behavior, then react-native-live-markdown needs to be updated such that it's using the new rule. Because right now it's confusing that the markdown processing in the composer is different than what we show in the chat. I think this is a legitimate blocker.
TBH I think we should have a full regression test on Expensify/react-native-live-markdown#360, so I'm not sure that we should push it forward and CP a package bump in App. So that leaves us with adding a patch or demoting this to NAB since we know the root cause and will have a fix out soon
changed the title [-][$250] mWeb - Chat - Quote markdown is not applied[/-][+][HOLD for payment 2024-06-21] [$250] mWeb - Chat - Quote markdown is not applied[/+]on Jun 20, 2024
Activity
melvin-bot commentedon Jun 6, 2024
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 6, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 6, 2024
@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 6, 2024
We think that this bug might be related to #vip-vsp
dragnoir commentedon Jun 6, 2024
Not a deploy blocker.
Offended PR Expensify/expensify-common#691
this is a new expected behavior:
roryabraham commentedon Jun 6, 2024
If this is indeed the new expected behavior, then react-native-live-markdown needs to be updated such that it's using the new rule. Because right now it's confusing that the markdown processing in the composer is different than what we show in the chat. I think this is a legitimate blocker.
roryabraham commentedon Jun 6, 2024
These are our options:
expensify-commonusage in NewDot #42387in any event, both PRs need to be included in the same release, or we'll have this inconsistency
luacmartins commentedon Jun 6, 2024
I think reverting #42387 might not be a good solution since there's at least another PR that depends on it #42504
luacmartins commentedon Jun 6, 2024
TBH I think we should have a full regression test on Expensify/react-native-live-markdown#360, so I'm not sure that we should push it forward and CP a package bump in App. So that leaves us with adding a patch or demoting this to NAB since we know the root cause and will have a fix out soon
31 remaining items
ishpaul777 commentedon Jun 19, 2024
@luacmartins/ @mountiny Can we please assign a BZ member for payment
melvin-bot commentedon Jun 20, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-][$250] mWeb - Chat - Quote markdown is not applied[/-][+][HOLD for payment 2024-06-21] [$250] mWeb - Chat - Quote markdown is not applied[/+]melvin-bot commentedon Jul 4, 2024
@anmurali, @luacmartins, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jul 8, 2024
@anmurali, @luacmartins, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
anmurali commentedon Jul 10, 2024
Paid.