Skip to content

Group chat - Not here page is hidden behind chat member profile page when URL modified #43212

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.80-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #43027

Action Performed:

  1. Log in to New Expensify
  2. Click FAB > Start chat
  3. create a group chat
  4. Open the group chat > Click on header > Members
  5. Click on any member > Profile
  6. Modify the url by adding a random string to the url

Expected Result:

"Hmm... it's not here" should be displayed in RHP as it is the case in 1:1 chats

Actual Result:

Member profile pages remains in RHP, not here page can be seen if you tap on back arrow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504171_1717693912593.2024-06-06_19-09-07.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 6, 2024
  2. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 6, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 6, 2024

    @lanitochka17
    Author

    @amyevans FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. removed
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 6, 2024
  6. amyevans commented on Jun 6, 2024

    @amyevans
    Contributor

    Modify the url by adding a random string to the url

    In this case of modifying the group chat profile URL (/a/<accountID>?backTo=<reportID>/participants/<accountID>), you are modifying the query string, not the actual route, so the behavior is expected in my opinion. Pressing the back button results in a Not Found page because that was the part that was modified.

    So I think this can be closed as expected behavior.

    cc @s77rt @marcaaron though since you have more context, feel free to reopen the issue if you disagree with me and think it should be treated as a bug.

  7. s77rt commented on Jun 6, 2024

    @s77rt
    Member

    Agree not a bug. @lanitochka17 FWIW in the test I meant to modify the url before clicking on the "Profile" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions