You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Group chat - Not here page is hidden behind chat member profile page when URL modified #43212
Version Number: 1.4.80-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@amyevans FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Modify the url by adding a random string to the url
In this case of modifying the group chat profile URL (/a/<accountID>?backTo=<reportID>/participants/<accountID>), you are modifying the query string, not the actual route, so the behavior is expected in my opinion. Pressing the back button results in a Not Found page because that was the part that was modified.
So I think this can be closed as expected behavior.
cc @s77rt@marcaaron though since you have more context, feel free to reopen the issue if you disagree with me and think it should be treated as a bug.
Activity
melvin-bot commentedon Jun 6, 2024
Triggered auto assignment to @amyevans (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 6, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 6, 2024
@amyevans FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
amyevans commentedon Jun 6, 2024
In this case of modifying the group chat profile URL (
/a/<accountID>?backTo=<reportID>/participants/<accountID>), you are modifying the query string, not the actual route, so the behavior is expected in my opinion. Pressing the back button results in a Not Found page because that was the part that was modified.So I think this can be closed as expected behavior.
cc @s77rt @marcaaron though since you have more context, feel free to reopen the issue if you disagree with me and think it should be treated as a bug.
s77rt commentedon Jun 6, 2024
Agree not a bug. @lanitochka17 FWIW in the test I meant to modify the url before clicking on the "Profile" button.