Skip to content

[HOLD for payment 2024-07-15] [Payment card / Subscription] Localize subscription prices to appropriate currency #43277

Closed

Description

@amyevans

Coming from this thread in the "Subscription settings" UI implementation PR, we should display all prices in the Subscription section of the app localized to the user's currency.

For example, the text

saveUpTo: 'Save up to $10/month per active member',

would show GBP if that is your billing currency.

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. MrMuzyk commented on Jun 27, 2024

    @MrMuzyk
    Contributor

    I am Michał from Callstack - expert contributor group. I’d like to work on this job.

  2. trjExpensify commented on Jun 27, 2024

    @trjExpensify
    Contributor

    @blimpich assigning you for vis.

  3. self-assigned this
    on Jun 27, 2024
  4. melvin-bot commented on Jun 27, 2024

    @melvin-bot

    Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  5. added
    ReviewingHas a PR in review
    and removed on Jun 27, 2024
  6. 18 remaining items

  7. trjExpensify commented on Jul 11, 2024

    @trjExpensify
    Contributor

    Changed to 15th!

  8. changed the title [-][HOLD for payment 2024-07-17] [Payment card / Subscription] Localize subscription prices to appropriate currency[/-] [+][HOLD for payment 2024-07-15] [Payment card / Subscription] Localize subscription prices to appropriate currency[/+] on Jul 11, 2024
  9. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @MrMuzyk is from an agency-contributor and not due payment
    • ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. changed the title [-][HOLD for payment 2024-07-15] [Payment card / Subscription] Localize subscription prices to appropriate currency[/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-15] [Payment card / Subscription] Localize subscription prices to appropriate currency[/+] on Jul 15, 2024
  11. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

    • @MrMuzyk does not require payment (Contractor)
    • @allgandalf requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  13. allgandalf commented on Jul 16, 2024

    @allgandalf
    Contributor

    Can you pay this one out please @trjExpensify , IDK why melvin is acting soo weird, the payment was due on 15th

  14. trjExpensify commented on Jul 16, 2024

    @trjExpensify
    Contributor

    Yep! Payment summary as follows:

    Sent you an offer. We don't need a regression test here, they'll be added centrally for the project as we wrap it up.

  15. changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-15] [Payment card / Subscription] Localize subscription prices to appropriate currency[/-] [+][HOLD for payment 2024-07-15] [Payment card / Subscription] Localize subscription prices to appropriate currency[/+] on Jul 16, 2024
  16. allgandalf commented on Jul 16, 2024

    @allgandalf
    Contributor

    accepted thanks

  17. trjExpensify commented on Jul 16, 2024

    @trjExpensify
    Contributor

    Paid, closing!

  18. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions