HOLD for Payment 2024-06-21] Verification page is included in the last path visited url

@adamgrzybowski

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @adamgrzybowski
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717758022288149

Action Performed:

With the ideal nav framework, we are storing the last visited url for the user. This way, we can ensure user is navigated where they left off.

User the abracadabra page when signing in
Close the tab when on the page
Open new dot in a new tab

Expected Result:

Describe what you think should've happened

User should be navigated to the main home page/ chats

Actual Result:

Describe what actually happened

User is presented with the abracadabra page but they are already signed in so no need for it

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rushatgabhane

@rushatgabhane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@adamgrzybowski

@adamgrzybowski - Can you comment here so I can assign you?

@AndrewGable

@AndrewGable 👋

PR hit production 2 days ago - #43303 (comment)

The PR that introduced the bug has been identified. Link to the PR: N.A. was always a problem.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

           1. Open the verification page - https://staging.new.expensify.com/v/123/456
           2. Open the home page - https://staging.new.expensify.com
           3. Verify that you aren't shown the magic code verification page

@sakluger

@sakluger could you please attach payment summary for the payment date - June 21

@adamgrzybowski

Summarizing payment on this issue:

Contributor: @adamgrzybowski - no payment due
Contributor+: @rushatgabhane - $250 - please request on Newdot on or after June 21

Posted! I'm going to leave this open until the payment date.

@rushatgabhane

$250 approved for @rushatgabhane.

Navigation Menu

Repository navigation

HOLD for Payment 2024-06-21] Verification page is included in the last path visited url #43325

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

HOLD for Payment 2024-06-21] Verification page is included in the last path visited url #43325

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 7, 2024

melvin-bot commented on Jun 7, 2024

AndrewGable commented on Jun 11, 2024

adamgrzybowski commented on Jun 12, 2024

rushatgabhane commented on Jun 16, 2024

rushatgabhane commented on Jun 16, 2024

rushatgabhane commented on Jun 16, 2024

sakluger commented on Jun 17, 2024

sakluger commented on Jun 17, 2024

JmillsExpensify commented on Jun 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions