[$250] [HOLD for payment 2024-07-10] [HybridApp] Do not allow logout in NewDot HybridApp

@staszekscp

Problem

If a user logs out of HybridApp via NewDot, many weird things can happen including crashes.

Solution

Do not allow HybridApp users to logout via NewDot

cc @staszekscp

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01970b1b535b50d220
Upwork Job ID: 1810704730661899086
Last Price Increase: 2024-07-09

Issue Owner

Current Issue Owner: @

Hopefully will get to this tomorrow

Ok so I think we need to actually expand the scope of this one a bit:

Do not show the logout button on NewDot
Anytime we are going to log out of NewDot, we should go back to OldApp and then log the user out there (if we have to)

The reason is we cannot support the NewDot sign in page for HybridApp, since OldApp contains all the authentication logic for HybridApp.

@shawnborton

@shawnborton is still having issues with an automatic log out:

RPReplay_Final1718212810.MP4

We should look for logs to determine why he is being kicked out.

@AndrewGable

@AndrewGable Eep! 4 days overdue now. Issues have feelings too...

Going to look into this one soon

@WoLewicki

cc @WoLewicki - I was thinking this could be a good issue to look into.

Basically we do not want to ever go to the NewDot login page on HybridApp.

We want to hide the Sign out button if we are on HybridApp
When the user should be signed out automatically (due to an authentication error), we want to exit NewDot instead of showing them the login page on NewDot.

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Job added to Upwork: https://www.upwork.com/jobs/~01970b1b535b50d220

@akinwale

Current assignee @akinwale is eligible for the External assigner, not assigning anyone new.

@akinwale

@akinwale can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01970b1b535b50d220

@abekkala , please pay tomorrow, PR hit production July 3. Thx

@mallenexpensify

@mallenexpensify I did not receive an offer for the job. Do I just go ahead to submit a proposal on Upwork?

Strange, I probably messed something up. You should be able to accept the job now.
https://www.upwork.com/jobs/~01970b1b535b50d220

@WoLewicki

PAYMENT SUMMARY FOR JULY 10

Fix: @WoLewicki - SWM, no payment needed
PR Review: [$250] payment sent and contract ended - thank you! 🎉

Navigation Menu

Repository navigation

[$250] [HOLD for payment 2024-07-10] [HybridApp] Do not allow logout in NewDot HybridApp #43336

Problem

Solution

21 remaining items

PAYMENT SUMMARY FOR JULY 10

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] [HOLD for payment 2024-07-10] [HybridApp] Do not allow logout in NewDot HybridApp #43336

Description

Problem

Solution

Activity

AndrewGable commented on Jun 10, 2024

AndrewGable commented on Jun 11, 2024

AndrewGable commented on Jun 12, 2024

melvin-bot commented on Jun 17, 2024

AndrewGable commented on Jun 18, 2024

AndrewGable commented on Jun 19, 2024

21 remaining items

melvin-bot commented on Jul 9, 2024

melvin-bot commented on Jul 9, 2024

melvin-bot commented on Jul 9, 2024

mallenexpensify commented on Jul 9, 2024

akinwale commented on Jul 9, 2024

mallenexpensify commented on Jul 10, 2024

abekkala commented on Jul 10, 2024

PAYMENT SUMMARY FOR JULY 10

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions