[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [MEDIUM] Debugability: Add username/accountID to the Ping command so we can diagnose problems with it better

@sakluger

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

What performance issue do we need to solve?

e.g. memory consumption, storage read/write times, React native bridge concerns, inefficient React component rendering, etc.

We use PING to track responsiveness between client, server and db. Currently, we do not log the user's username when the PING command is executed, so when reviewing the server-side logs, it's hard to find the logline for a PING.

What is the impact of this on end-users?

List specific user experiences that will be improved by solving this problem e.g. app boot time, time to for some interaction to complete, etc.

This is a debugging issue, where this will help us triage connectivity issues with clients.

List any benchmarks that show the severity of the issue

Please also provide exact steps taken to collect metrics above if any so we can independently verify the results.

N/A

Proposed solution (if any)

Please list out the steps you think we should take to solve this issue.

Add the user's accountID to PING so we can easily trace them in the server side logs.

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Note: These should be the same as the benchmarks collected before any changes.

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on Upwork

Issue Owner

Current Issue Owner: @sakluger

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

I'll take this one and work on it.

Daily Update

I've created an App PR to implement this

Next Steps

Wait for PR to be reviewed and merged

ETA

Deployed by tomorrow, June 11

Commenting here, I reviewed the PR as C+

@alitoshmatov

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Add user's accountID to the api/ping command #43385

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment (Needs manual offer from BZ)

@alitoshmatov

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Automation is having some hiccup, PR was deployed on june 18 and payment is due today. Checklist is not needed as I mentioned here.

@alitoshmatov

Thanks for the comment @alitoshmatov, and sorry for the delayed payment!

Summarizing payment on this issue:

Contributor+: @alitoshmatov $250, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/102892849)

@alitoshmatov

@alitoshmatov let me know once you've accepted the offer. Thanks!

@sakluger

@sakluger Accepted the offer

Thanks! I completed the payment.

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [MEDIUM] Debugability: Add username/accountID to the Ping command so we can diagnose problems with it better #43354

What performance issue do we need to solve?

What is the impact of this on end-users?

List any benchmarks that show the severity of the issue

Proposed solution (if any)

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Platforms:

Daily Update

Next Steps

ETA

18 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [MEDIUM] Debugability: Add username/accountID to the Ping command so we can diagnose problems with it better #43354

Description

What performance issue do we need to solve?

What is the impact of this on end-users?

List any benchmarks that show the severity of the issue

Proposed solution (if any)

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Platforms:

Activity

melvin-bot commented on Jun 10, 2024

tgolen commented on Jun 10, 2024

tgolen commented on Jun 10, 2024

Daily Update

Next Steps

ETA

alitoshmatov commented on Jun 13, 2024

18 remaining items

melvin-bot commented on Jun 21, 2024

melvin-bot commented on Jun 21, 2024

alitoshmatov commented on Jun 23, 2024

sakluger commented on Jun 26, 2024

sakluger commented on Jun 27, 2024

alitoshmatov commented on Jun 27, 2024

sakluger commented on Jun 28, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions